Skip to content

jetpack-mu-wpcom: Enable Classic block inserter support via sticker#48526

Open
yuliyan wants to merge 4 commits intotrunkfrom
enable/classic-block-inserter-support
Open

jetpack-mu-wpcom: Enable Classic block inserter support via sticker#48526
yuliyan wants to merge 4 commits intotrunkfrom
enable/classic-block-inserter-support

Conversation

@yuliyan
Copy link
Copy Markdown
Member

@yuliyan yuliyan commented May 5, 2026

Proposed changes

  • Allow sites with the enable-classic-block-inserter-support sticker to opt in to Classic block inserter support.
  • When the sticker is present, add the wp_classic_block_supports_inserter filter with __return_true.

Related:

Previous attempt to allow enabling Classic block support:

Related product discussion/links

phcsdm-1cI-p2#comment-1711

Does this pull request change what data or activity we track or use?

No

Testing instructions

  • Use a site running a Gutenberg build that includes the wp_classic_block_supports_inserter filter. If the filter is wrapped in an experiment, make sure the experiment is enabled.
  • Confirm the site does not have the enable-classic-block-inserter-support sticker.
  • Open the block editor for a post or page.
  • Open the block inserter and search for "Classic".
  • Confirm the Classic block is not available for manual insertion.
  • Add the enable-classic-block-inserter-support sticker to the site.
  • Reload the editor.
  • Open the block inserter and search for "Classic".
  • Confirm the Classic block is available and can be inserted.

@yuliyan yuliyan requested a review from tyxla May 5, 2026 12:53
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the enable/classic-block-inserter-support branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin enable/classic-block-inserter-support

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@yuliyan yuliyan added [Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. labels May 5, 2026
@github-actions github-actions Bot added the [Package] Jetpack mu wpcom WordPress.com Features label May 5, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 5, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 5, 2026
@yuliyan yuliyan added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 5, 2026
@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented May 5, 2026

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php 2/354 (0.56%) -0.00% 2 ❤️‍🩹

Full summary · PHP report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

tyxla
tyxla previously approved these changes May 5, 2026
Copy link
Copy Markdown
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor fix

Let's merge after GB 23.1 has been released.

Comment thread projects/packages/jetpack-mu-wpcom/src/class-jetpack-mu-wpcom.php Outdated
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Blocks Issues related to the block editor, aka Gutenberg, and its extensions developed in Jetpack I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Jetpack mu wpcom WordPress.com Features [Status] Needs Review This PR is ready for review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants