Skip to content

Use Link instead of ExternalLink #48529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbradsha merged 14 commits into from
May 6, 2026
Merged

Use Link instead of ExternalLink #48529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
effdb8a
Bump @wordpress/eslint-plugin to 25.1.0
tbradsha May 5, 2026
bd50c86
<ExternalLink /> → <Link openInNewTab />
tbradsha May 5, 2026
6f9fc0b
Update createInterpolateElement() calls, tests, and docs
tbradsha May 5, 2026
b8b2bf1
Add changelogs
tbradsha May 5, 2026
3493131
Use alternate local component name
tbradsha May 5, 2026
7bcf595
Use BundledWpPkgsTranspileRules() in Forms webpack config
tbradsha May 5, 2026
25d05ee
Rename local Link component to AnchorBlock
tbradsha May 5, 2026
7c26d55
Use BundledWpPkgsTranspileRules() in Jetpack webpack config
tbradsha May 5, 2026
41a1b2f
Avoid transitive react dependency
tbradsha May 5, 2026
f54678e
Remove redundant wrapper
tbradsha May 5, 2026
ec26b3d
Update snapshot
tbradsha May 5, 2026
581f21e
More BundledWpPkgsTranspileRules()
tbradsha May 5, 2026
40f208f
Merge branch 'trunk' into update/eslint/use_wp_recommended_components…
tbradsha May 6, 2026
38bc566
Update pnpm-lock.yaml
tbradsha May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 70 additions & 16 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions ...lient/changelog/update-eslint-use_wp_recommended_components_link_instead_of_external_link
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Components: Use Link from `@wordpress/ui` instead of ExternalLink.
1 change: 1 addition & 0 deletions projects/js-packages/ai-client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
"@wordpress/i18n": "6.17.0",
"@wordpress/icons": "12.2.0",
"@wordpress/primitives": "4.44.0",
"@wordpress/ui": "0.11.0",
"@wordpress/url": "4.44.0",
"clsx": "2.1.1",
"debug": "4.4.3",
Expand Down
10 changes: 6 additions & 4 deletions projects/js-packages/ai-client/src/components/message/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,11 @@
/**
* External dependencies
*/
import { ExternalLink, Button } from '@wordpress/components';
import { Button } from '@wordpress/components';
import { createInterpolateElement } from '@wordpress/element';
import { __, sprintf } from '@wordpress/i18n';
import { Icon, check } from '@wordpress/icons';
import { Link } from '@wordpress/ui';
import clsx from 'clsx';
/**
* Internal dependencies
Expand Down Expand Up @@ -126,9 +127,9 @@ export default function Message( {
*/
function LearnMoreLink(): ReactElement {
return (
<ExternalLink href="https://jetpack.com/redirect/?source=ai-guidelines">
<Link openInNewTab href="https://jetpack.com/redirect/?source=ai-guidelines">
{ __( 'Learn more', 'jetpack-ai-client' ) }
</ExternalLink>
</Link>
);
}

Expand Down Expand Up @@ -169,7 +170,8 @@ export function FairUsageLimitMessage(): ReactElement {
);
const element = createInterpolateElement( message, {
link: (
<ExternalLink
<Link
openInNewTab
href="https://jetpack.com/redirect/?source=ai-assistant-fair-usage-policy"
children={ null }
/>
Expand Down
4 changes: 4 additions & 0 deletions ...nents/changelog/update-eslint-use_wp_recommended_components_link_instead_of_external_link
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Components: Use Link from `@wordpress/ui` instead of ExternalLink.
5 changes: 2 additions & 3 deletions projects/js-packages/components/components/jetpack-footer/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,12 +69,12 @@ const JetpackFooter: FC< JetpackFooterProps > = ( { className, menu, ...otherPro
return (
<li key={ item.label }>
<Text
variant="body-sm"
variant="body-md"
className="jetpack-footer__menu-item"
render={
isButton ? (
<Link
render={ <Text variant="body-md" render={ <span /> } /> }
render={ <span /> }
tone="neutral"
variant="default"
role={ item.role }
Expand All @@ -84,7 +84,6 @@ const JetpackFooter: FC< JetpackFooterProps > = ( { className, menu, ...otherPro
/>
) : (
<Link
render={ <Text variant="body-md" render={ <a /> } /> }
tone="neutral"
variant="default"
href={ item.href || '' }
Expand Down
8 changes: 4 additions & 4 deletions ...ts/js-packages/components/components/jetpack-footer/test/__snapshots__/component.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ exports[`JetpackFooter Render the component should match the snapshot: all props
>
<li>
<a
class="_83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md _2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _0e8d87a42c1f75fa__body-sm jetpack-footer__menu-item"
class="_2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md jetpack-footer__menu-item"
href="undefinedadmin.php?page=my-jetpack#/products"
title=""
>
Expand All @@ -54,7 +54,7 @@ exports[`JetpackFooter Render the component should match the snapshot: all props
</li>
<li>
<a
class="_83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md _2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _0e8d87a42c1f75fa__body-sm jetpack-footer__menu-item"
class="_2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md jetpack-footer__menu-item"
href="undefinedadmin.php?page=my-jetpack#/help"
title=""
>
Expand All @@ -63,7 +63,7 @@ exports[`JetpackFooter Render the component should match the snapshot: all props
</li>
<li>
<a
class="_83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md _2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _0e8d87a42c1f75fa__body-sm jetpack-footer__menu-item"
class="_2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md jetpack-footer__menu-item"
href="/"
title=""
>
Expand All @@ -72,7 +72,7 @@ exports[`JetpackFooter Render the component should match the snapshot: all props
</li>
<li>
<span
class="_83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md _2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _0e8d87a42c1f75fa__body-sm jetpack-footer__menu-item"
class="_2c0831b0499dbd6e__a _336cd3e4e743482f__box-sizing _08e8a2e44959f892__outset-ring--focus d4250949359b05ce__link _92e0dfcaeee15b88__is-neutral _83ed8a8da5dd50ea__text _43cec3e1eec1066d__p _131101940be12424__body-md jetpack-footer__menu-item"
role="button"
tabindex="0"
>
Expand Down
Loading
Loading