Plugin Conflicts Guardian: default pcg_guard_activation to true#48553
Open
arthur791004 wants to merge 1 commit intotrunkfrom
Open
Plugin Conflicts Guardian: default pcg_guard_activation to true#48553arthur791004 wants to merge 1 commit intotrunkfrom
arthur791004 wants to merge 1 commit intotrunkfrom
Conversation
Activation guard, install/update parse-error gate, and the activation-mode probe endpoint now default on. pcg_guard_updates is unchanged (still defaults false), so the probe endpoint splits the gate default per mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
Code Coverage SummaryCoverage changed in 1 file.
|
taipeicoder
approved these changes
May 6, 2026
Contributor
taipeicoder
left a comment
There was a problem hiding this comment.
As a follow-up PR, can we add logstash for activations that we managed to block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes
pcg_guard_activationfilter fromfalsetotrue, so the Plugin Conflicts Guardian activation probe and the install/update parse-error gate are on by default.probe-endpoint.phpso activation-mode probes inherit the newtruedefault while update-mode probes (gated bypcg_guard_updates) keep defaulting tofalse.Related product discussion/links
Does this pull request change what data or activity we track or use?
No.
Testing instructions
jetpack-mu-wpcomto a test site (no extra filter wiring needed).add_filter( 'pcg_guard_activation', '__return_false' );in an mu-plugin and confirm activations are no longer probed (back to core behavior).pcg_guard_updatesflow remains off unless explicitly enabled — installing/updating a plugin does not trigger the post-update health-check + rollback path.