Skip to content

Plugin Conflicts Guardian: default pcg_guard_activation to true#48553

Open
arthur791004 wants to merge 1 commit intotrunkfrom
try/pcg-guard-activation-default-true
Open

Plugin Conflicts Guardian: default pcg_guard_activation to true#48553
arthur791004 wants to merge 1 commit intotrunkfrom
try/pcg-guard-activation-default-true

Conversation

@arthur791004
Copy link
Copy Markdown
Contributor

Fixes #

Proposed changes

  • Flip the default of the pcg_guard_activation filter from false to true, so the Plugin Conflicts Guardian activation probe and the install/update parse-error gate are on by default.
  • Split the gate default in probe-endpoint.php so activation-mode probes inherit the new true default while update-mode probes (gated by pcg_guard_updates) keep defaulting to false.
  • Update the feature README to reflect the new defaults.

Related product discussion/links

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  • Sync jetpack-mu-wpcom to a test site (no extra filter wiring needed).
  • In wp-admin → Plugins, activate a known-good plugin: activation succeeds normally (probe runs, returns clean).
  • Activate a plugin known to fatal on load: activation is blocked with the Plugin Conflicts Guardian admin notice naming the plugin.
  • Upload-install a zip containing a PHP parse error: install is refused with a parse-error notice.
  • Add add_filter( 'pcg_guard_activation', '__return_false' ); in an mu-plugin and confirm activations are no longer probed (back to core behavior).
  • Confirm pcg_guard_updates flow remains off unless explicitly enabled — installing/updating a plugin does not trigger the post-update health-check + rollback path.

Activation guard, install/update parse-error gate, and the activation-mode
probe endpoint now default on. pcg_guard_updates is unchanged (still
defaults false), so the probe endpoint splits the gate default per mode.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@arthur791004 arthur791004 added the [Status] Needs Review This PR is ready for review. label May 6, 2026
@arthur791004 arthur791004 self-assigned this May 6, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the try/pcg-guard-activation-default-true branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin try/pcg-guard-activation-default-true

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 6, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control
Copy link
Copy Markdown

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/plugin-conflicts-guardian/probe-endpoint.php 0/82 (0.00%) 0.00% 2 ❤️‍🩹

Full summary · PHP report

@arthur791004 arthur791004 requested a review from taipeicoder May 6, 2026 11:03
Copy link
Copy Markdown
Contributor

@taipeicoder taipeicoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a follow-up PR, can we add logstash for activations that we managed to block?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants