-
Notifications
You must be signed in to change notification settings - Fork 875
Podcast: wp-build dashboard scaffold + Jetpack > Podcast menu (2/4) #48557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: changed | ||
|
|
||
| Podcast: initialize the jetpack-podcast package from jetpack-mu-wpcom (so Simple sites pick it up where load-jetpack.php doesn't run), and when the `jetpack_podcast_untangle` filter is on, register the new in-admin "Jetpack > Podcast" page in place of the legacy Calypso "Podcasting" link. Default behavior (filter off) is unchanged. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| vendor/ | ||
| node_modules/ | ||
| .cache/ | ||
| build/ | ||
| composer.lock |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| build/ |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: added | ||
|
|
||
| Add an empty wp-build dashboard scaffold and the "Jetpack > Podcast" wp-admin entry, gated behind the `jetpack_podcast_untangle` filter. With the filter off (default), nothing changes; with it on, a placeholder Podcast page renders inside the standard wp-admin chrome. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,5 +13,41 @@ | |
| "directory": "projects/packages/podcast" | ||
| }, | ||
| "license": "GPL-2.0-or-later", | ||
| "author": "Automattic" | ||
| "author": "Automattic", | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "pnpm run clean && pnpm run build:wp-build && pnpm run build:boot-asset", | ||
| "build:boot-asset": "provide-boot-asset-file", | ||
| "build:wp-build": "wp-build", | ||
| "build-production": "pnpm run clean && pnpm run build:wp-build && pnpm run build:boot-asset", | ||
| "clean": "rm -rf build/", | ||
| "watch": "wp-build --watch" | ||
| }, | ||
| "browserslist": [ | ||
| "extends @wordpress/browserslist-config" | ||
| ], | ||
| "devDependencies": { | ||
| "@automattic/jetpack-wp-build-polyfills": "workspace:*", | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I would expect polyfills in composer file instead as
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This I believe it's a hybrid. The Composer side ships the I tried to remove this and tests started breaking. Maybe I am missing something though. |
||
| "@babel/core": "7.29.0", | ||
| "@babel/runtime": "7.29.2", | ||
| "@types/react": "18.3.28", | ||
| "@wordpress/browserslist-config": "6.44.0", | ||
| "@wordpress/build": "0.13.0", | ||
| "@wordpress/element": "6.44.0", | ||
| "@wordpress/i18n": "6.17.0", | ||
| "browserslist": "^4.24.0" | ||
| }, | ||
| "optionalDependencies": { | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1" | ||
| }, | ||
| "wpPlugin": { | ||
| "name": "jetpack_podcast", | ||
| "scriptGlobal": "jetpackPodcast", | ||
| "packageNamespace": "jetpack-podcast", | ||
| "handlePrefix": "jetpack-podcast", | ||
| "pages": [ | ||
| "jetpack-podcast-dashboard" | ||
| ] | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "name": "_@jetpack-podcast/dashboard-route", | ||
| "version": "1.0.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "@types/react": "18.3.28", | ||
| "@wordpress/element": "6.44.0", | ||
| "@wordpress/i18n": "6.17.0" | ||
| }, | ||
| "route": { | ||
| "path": "/", | ||
| "page": "jetpack-podcast-dashboard" | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const route = {}; |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| const Stage = () => { | ||
| // "Podcast" is a product name, do not translate. | ||
| return <h1>Podcast</h1>; | ||
| }; | ||
|
|
||
| export { Stage as stage }; |
Uh oh!
There was an error while loading. Please reload this page.