Podcast: page chrome + empty tabs in dashboard route (3/4)#48559
Podcast: page chrome + empty tabs in dashboard route (3/4)#48559arcangelini merged 4 commits intotrunkfrom
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: No scheduled milestone found for this plugin. If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
9218978 to
f632099
Compare
99a0f0d to
8005a9e
Compare
PR 3 of 4 in the Podcast untangle train
Proposed changes
Replaces the wp-build
<h1>Podcast</h1>placeholder with page chrome (title, tagline) plus a four-tab navigation (Welcome, Settings, Episodes, Distribution) using@wordpress/uiTabs. Each tab panel renders an empty placeholder. Still gated behind thejetpack_podcast_untanglefilter (PR 1) — no behavior change for any user with the filter off.The full
AdminPageintegration from@automattic/jetpack-components\(with footer, base-styles SCSS, etc.) lands together with the real tab contents in PR 4 — keeping that wiring out of the scaffold avoids draggingnumber-formatters/base-stylestransitive deps through wp-build's bundler before they're needed.Stacked on #48557. Upstream consolidation PR: #48499.
Does this pull request change what data or activity we track or use?
No.
Testing instructions
add_filter( 'jetpack_podcast_untangle', '__return_true' );/wp-adminand make sure Podcast (not PodcastING) shows under Jetpack