Plugin Conflicts Guardian: default pcg_guard_updates to true#48595
Open
arthur791004 wants to merge 1 commit intotrunkfrom
Open
Plugin Conflicts Guardian: default pcg_guard_updates to true#48595arthur791004 wants to merge 1 commit intotrunkfrom
arthur791004 wants to merge 1 commit intotrunkfrom
Conversation
Post-update health check, snapshot capture, and the update-mode probe endpoint now default on. Mirrors the prior pcg_guard_activation default-true switch — both gates can now also drop the per-mode default split in probe-endpoint.php and apply true uniformly. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Contributor
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
taipeicoder
approved these changes
May 7, 2026
Code Coverage SummaryCoverage changed in 1 file.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Follow-up to #48553 (which flipped
pcg_guard_activationto default true). This flips the second gate,pcg_guard_updates, the same way:update-healthcheck.php— bothapply_filters( 'pcg_guard_updates', false )callsites (snapshot capture onupgrader_pre_install, post-update healthcheck onupgrader_process_complete) now defaulttrue.probe-endpoint.php— drops the per-mode default split ($gate_default = ! $is_update_mode) introduced when only activation defaulted on. With both gates now default true the probe endpoint appliestrueuniformly:apply_filters( $gate_filter, true ).README.md— updates thepcg_guard_updatesline to "Defaultstrue."No behavior change for sites that have explicitly filtered
pcg_guard_updatestofalse. For everyone else: post-update probes run, and a fatal-on-update triggers the snapshot-based rollback flow that PCG already had wired up but defaulted dark.Related product discussion/links
pcg_guard_activationto true).Does this pull request change what data or activity we track or use?
Indirectly —
pcg_guard_updatescontrols whether theUpdate rolled backlogstash event from #48565 fires in the wild. The event payload itself is unchanged.Testing instructions
jetpack-mu-wpcomto a test site (no explicitpcg_guard_updatesfilter set).Update rolled backrow lands in theplugin-conflicts-guardianlogstash bucket.add_filter( 'pcg_guard_updates', '__return_false' );and repeat — expected: snapshot is not captured, no probe runs, update completes (or fatals) without rollback.🤖 Generated with Claude Code