Fix source-less JS handle ordering#90
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts WPcom_JS_Concat::do_items() so that source-less (alias/group) script handles are deferred into the same ordered output queue as non-concatenated scripts, ensuring concatenated chunks are emitted before any inline output attached to those source-less handles (aligning more closely with WordPress core ordering).
Changes:
- Defer source-less script handles by queueing them as
do_itementries instead of printing immediately. - Add a regression test to validate ordering when
js_do_concatis disabled and a source-less handle has dependencies plus inline output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
jsconcat.php |
Defers source-less handles into the ordered $javascripts queue so pending concat chunks print before alias/group inline output. |
tests/test-jsconcat-order.php |
Adds a regression test that asserts output ordering for a source-less handle when concat is disabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sjinks
approved these changes
May 12, 2026
828799e to
ff54b55
Compare
ff54b55 to
5ef3ac9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description