[Tooling] Replace ActiveSupport's String#parameterize with a pure-Ruby helper#1808
Merged
Merged
Conversation
…y helper release-toolkit v14.3.1 dropped its `activesupport` runtime dependency, so `String#parameterize` (used in `generate_prototype_build_number`) will raise `NoMethodError` once the toolkit is bumped to >=14.3.1 (currently `~> 13.8`). Add a small pure-Ruby `parameterize` helper that reproduces the behavior we rely on. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
iangmaia
requested review from
Copilot and
twstokes
and removed request for
Copilot
iangmaia
added
the
tooling
Collaborator
|
📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.
|
Contributor
|
Thanks @iangmaia! I run into this issue in Gravatar's Android SDK Automattic/Gravatar-SDK-Android#683 but didn't think to check other repos. Shame on me. |
mokagio
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
release-toolkitv14.3.1 dropped itsactivesupportruntime dependency.generate_prototype_build_numberin ourFastfilestill callsString#parameterize, which will raiseNoMethodErroras soon as we bumprelease-toolkitto>= 14.3.1(currently pinned to~> 13.8). Proactive fix so the bump doesn't break Prototype Builds —wordpress-androidalready hit this.Adds a tiny pure-Ruby
parameterizehelper (downcase, replace runs of non-[a-z0-9_-]with-, squeeze, strip leading/trailing-) and routes the two call sites through it. Output matches ActiveSupport'sString#parameterizefor the branch/commit names involved.Test
ruby -c fastlane/Fastfilepasses.Review
The helper is a drop-in replacement for the two
.parameterizecall sites; behavior is unchanged for the inputs we pass (git branch / ref names).Release
Release notes are not needed (CI/tooling only).
🤖 Generated with Claude Code