Fix fetch failed due to unsupported expect header#2906
Closed
rinatkhaziev wants to merge 1 commit into
Closed
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Contributor
Author
|
superseded by #2905 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This pull request adds a new utility to strip unsupported HTTP headers (specifically the
Expectheader) from requests made to S3, and introduces a test to verify this behavior in theuploadImportFileToS3function. This ensures better compatibility with theundiciHTTP client and S3 presigned URLs.Testing and Bug Fixes:
uploadImportFileToS3in__tests__/lib/client-file-uploader.jsto verify that unsupportedExpectheaders are stripped from presigned S3 uploads.uploadImportFileToS3into the test file to enable testing of the new behavior.HTTP Header Handling Improvements:
stripUndiciUnsupportedHeadersutility to remove unsupported headers (likeExpect) from HTTP requests before sending them withundici.fetchWithRetryto usestripUndiciUnsupportedHeaderson all outgoing requests, improving compatibility and preventing errors with S3 and theundiciclient.Headersclass fromundicito support header manipulation.Pull request checklist
New release checklist
Steps to Test
Outline the steps to test and verify the PR here.
Example:
npm run build./dist/bin/vip-cookies.js nom