Use SiteInfo to create WpService#1239
Merged
Merged
Conversation
Collaborator
XCFramework BuildThis PR's XCFramework is available for testing. Add to your .package(url: "https://github.com/automattic/wordpress-rs", branch: "pr-build/1239")Built from d3a6c53 |
crazytonyli
force-pushed
the
task/unifi-wp-service-constructor
branch
3 times, most recently
from
06327b7 to
f95fe31
Compare
crazytonyli
force-pushed
the
task/unifi-wp-service-constructor
branch
2 times, most recently
from
5ae04c5 to
77c19d3
Compare
crazytonyli
force-pushed
the
task/unifi-wp-service-constructor
branch
from
77c19d3 to
28bc4ef
Compare
oguzkocer
approved these changes
Apr 22, 2026
Contributor
Author
|
@oguzkocer Thanks for the review! I'll merge this PR after the integration PR in the iOS app is approved. I want to merge these two PRs together to avoid blocking others. |
crazytonyli
force-pushed
the
task/unifi-wp-service-constructor
branch
from
28bc4ef to
008af36
Compare
crazytonyli
force-pushed
the
task/unifi-wp-service-constructor
branch
from
008af36 to
d3a6c53
Compare
1 task
crazytonyli
added a commit
that referenced
this pull request
May 4, 2026
* Tolerate URL normalization differences in cache lookups Register a `urls_eq` SQLite scalar function that compares two URL strings via `ParsedUrl` parsing (with raw-string fast path) and use it in `WHERE urls_eq(url, ?)` for `self_hosted_sites.url` reads. Lookups now match the same site whether it was stored as `http://localhost` or `http://localhost/`, which fixes the trunk integration-test break in `test_remove_site.rs` and removes the latent risk of duplicate rows on devices upgrading across PR #1239. Replaces the narrower `url_candidates` workaround (and the `delete_self_hosted_site_by_url(&[String])` overload that consumed it), so every URL-keyed read goes through one mechanism. * Make WpApiCache::from(Connection) fallible `register_url_functions` can fail at the SQLite layer; switch the impl from `From<Connection>` to `TryFrom<Connection>` so callers surface the error as `SqliteDbError` rather than panic. The four existing call sites are unit-test setup, which now `.expect(...)` the result. * Add a change log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are two separate constructors to create WpService, based on the type of the site. This PR unifies them by using the existing
SiteInfo.I have also updated the Swift wrapper
WordPressAPIto hold on to aSiteInfoinstance, to simplify the creating WpService API.