fix(logo): extend trunk to viewBox bottom for proper ground anchoring

[AutumnsGrove]

The Logo tree trunk previously ended at y=92 in a 100-unit viewBox,
leaving 8% empty space at the bottom. This caused the logo tree to
"float" above hills in forest scenes, as the translateY(-97%) positioning
assumed the visual bottom aligned with the viewBox bottom.

Extended trunk paths from y=92 to y=100 in both Logo.svelte and
GlassLogo.svelte, matching the behavior of other tree components
(e.g., TreePine) where the visual bottom reaches the viewBox edge.

[claude]

PR Review: Logo Trunk Extension for Ground Anchoring

Summary

This PR fixes a visual issue where the Logo tree appeared to float above hills in forest scenes by extending the trunk paths from y=92 to y=100 in both Logo.svelte and GlassLogo.svelte.

Strengths

1. Well-Identified Root Cause

The issue analysis is spot-on: the trunk ended at y=92 in a 100-unit viewBox, leaving 8% empty space. With the translateY(-97%) positioning used in forest scenes, this caused a visible gap between the tree base and the ground.

2. Consistent Implementation

Both Logo.svelte and GlassLogo.svelte were updated in parallel, maintaining consistency across the component variants.

3. Excellent Documentation

• Clear inline comments explaining the change
• Comprehensive commit message with context
• PR description articulates the problem and solution well

4. Alignment with Component Standards

The commit message references TreePine as precedent, which is correct—TreePine has elements at y=100.

5. Small, Focused Change

This is a surgical fix: 6 additions, 5 deletions across 2 files. No scope creep.

Code Quality Analysis

The SVG path changes are valid and correct:

• Path structure remains valid (M, L, Z commands)
• Trunk extends 8 units further down (92→100)
• Both dark and light paths maintain symmetry
• The slight taper is preserved

Testing Considerations

Manual testing recommended:

1. Forest Scene Integration - Verify logos no longer float above hills
2. Component Variants - Test both Logo and GlassLogo in forest scenes
3. Visual Regression - Logo should still look correct in non-forest contexts

The existing test file focuses on breathing animation and color computation. No tests validate SVG path geometry, which is acceptable for visual components.

Security & Performance

• No security concerns (pure SVG path data)
• No performance impact (static path strings)
• No accessibility impact (paths are presentational)

Checklist Review

• Code Quality: Clean, consistent changes
• Best Practices: Follows SVG standards
• Documentation: Excellent inline comments
• Consistency: Both Logo variants updated
• Test Coverage: No automated tests for this fix (acceptable)
• Visual Testing: Manual verification recommended

Design Alignment

This aligns with Grove design principles - Organic over rigid. The fix ensures the Logo tree respects the same ground-anchoring behavior as other tree components, creating visual consistency.

Suggestions

1. Visual Verification (Recommended): Take a screenshot before/after in the forest scene
2. Consider documenting this pattern: All tree components in 0-100 viewBox should extend to y=100 for proper ground anchoring
3. Optional: Add JSDoc comments to document the y=100 boundary

Verdict

APPROVED — This is a well-executed fix that addresses a legitimate visual issue with minimal risk.

The changes are:

• Correct: Extends trunk to viewBox boundary as intended
• Consistent: Both Logo variants updated identically
• Safe: Isolated to visual rendering with no functional impact
• Well-documented: Clear commit message and inline comments

The only recommendation is manual visual verification in the forest scene.

---

Grove Voice: This is the kind of quiet, thoughtful polish that makes Grove feel like a well-tended space. The trees now properly root themselves in the soil—exactly as they should.