Skip to content

Sync to latest commits from awk34 branch #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wclaiborne wants to merge 24 commits into
base: awk34-access-token-only
Choose a base branch
from
Open

Sync to latest commits from awk34 branch #1

Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
939242d
Allow saving a new refresh token sent from OAuth APIs when requesting…
Awk34 Jun 6, 2025
25acc52
Add support for saving & getting access tokens in OAuthStore
Awk34 Jun 5, 2025
9a10a16
Add support for OAuth APIs initially returning only access tokens rat…
Awk34 Jun 6, 2025
b8a34be
Throw `HTTP_BAD_REQUEST` rather than `HTTP_INTERNAL_ERROR` when no ac…
wclaiborne Jun 9, 2025
68e804d
Add unit test for case where response contains both a refresh token a…
wclaiborne Jun 9, 2025
12ff6da
Throw an error when refresh token does not write successfully.
wclaiborne Jun 9, 2025
e55d77a
Add refreshTokenResponse to error message when response does not have…
wclaiborne Jun 11, 2025
661e854
Add refreshTokenResponse to error message when response does not have…
wclaiborne Jun 11, 2025
3ee0805
Merge branch 'awk34-access-token-only' into awk34-access-token-only
wclaiborne Jun 24, 2025
7cff1c8
Add support for saving & getting access tokens in OAuthStore
Awk34 Jun 5, 2025
79d7c18
Add support for OAuth APIs initially returning only access tokens rat…
Awk34 Jun 6, 2025
20b1163
Throw `HTTP_BAD_REQUEST` rather than `HTTP_INTERNAL_ERROR` when no ac…
wclaiborne Jun 9, 2025
4b790d9
Add unit test for case where response contains both a refresh token a…
wclaiborne Jun 9, 2025
6b86663
Add refreshTokenResponse to error message when response does not have…
wclaiborne Jun 11, 2025
244042a
Add refreshTokenResponse to error message when response does not have…
wclaiborne Jun 11, 2025
a934385
Add support for saving & getting access tokens in OAuthStore
Awk34 Jun 5, 2025
f0c8ee0
Add support for OAuth APIs initially returning only access tokens rat…
Awk34 Jun 6, 2025
533cc98
Merge remote-tracking branch 'origin/awk34-access-token-only' into aw…
wclaiborne Jun 27, 2025
c83b012
Add support for saving & getting access tokens in OAuthStore
Awk34 Jun 5, 2025
bb29488
Add support for OAuth APIs initially returning only access tokens rat…
Awk34 Jun 6, 2025
928ea3d
Throw `HTTP_BAD_REQUEST` rather than `HTTP_INTERNAL_ERROR` when no ac…
wclaiborne Jun 9, 2025
30bdb5c
Add unit test for case where response contains both a refresh token a…
wclaiborne Jun 9, 2025
53b0e65
Add support for saving & getting access tokens in OAuthStore
Awk34 Jun 5, 2025
d78f66b
Merge remote-tracking branch 'origin/awk34-access-token-only' into aw…
wclaiborne Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...cdap-data-pipeline-base/src/main/java/io/cdap/cdap/datapipeline/service/OAuthHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,8 @@ public void putOAuthCredential(HttpServiceRequest request, HttpServiceResponder
if (!hasAccessToken && !hasRefreshToken) {
throw new OAuthServiceException(
HttpURLConnection.HTTP_BAD_REQUEST,
"Refresh token response body did not contain a refresh token or access token");
String.format("Refresh token response is missing the required access token or refresh token. See the full response body: %s", refreshTokenResponse);
);
}

if (hasRefreshToken) {
Expand Down