fix(migration): enhance migration logic to handle existing tables and…#24
Merged
fix(migration): enhance migration logic to handle existing tables and…#24
Conversation
… prevent duplicate migrations
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… prevent duplicate migrations
Note
Medium Risk
Changes migration execution control flow based on persisted state; incorrect detection or partial state could cause expected migrations to be skipped or rolled back unexpectedly.
Overview
Migration initialization now imports
TransactionHandlerfrom./transactionand, when the migration tracking table already exists, loads existing rows intocontext.itemsinstead of exiting blindly.run()usescontext.itemsto skipupmigrations that have already been recorded and to skipdownmigrations that were never applied, reducing duplicate/invalid migration executions and adding clearer console output when the migration table is already present.Written by Cursor Bugbot for commit 03b0136. This will update automatically on new commits. Configure here.