fix(builder): enhance createForeignKey to support onCreateTable option#26
Merged
fix(builder): enhance createForeignKey to support onCreateTable option#26
Conversation
…n and standardize reference property names
…d reference properties and ensure compatibility with new references structure
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
… option and ensure proper assignment of reference properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches SQL generation for foreign keys and option validation/normalization, so regressions could break migrations or produce invalid DDL for some input shapes despite added test coverage.
Overview
Adds an
onCreateTablemode toManageSQLBuilder.createForeignKeyso foreign keys can be rendered inline asCONSTRAINT ...clauses duringCREATE TABLE, while keeping the existingALTER TABLE ... ADD CONSTRAINTpath for standalone operations.Standardizes foreign-key option naming to
table/columnunderreferences(andtable/columnfor the target as well), with backward-compatible support for deprecatedreferenceandtableName/columnNameinputs across the builder, migrations API, and TypeScript definitions; tests are updated/added to cover both modern and legacy formats.Written by Cursor Bugbot for commit f95eab8. This will update automatically on new commits. Configure here.