Open
Conversation
anfibiacreativa
requested review from
gkulin and
kristenwomack
as code owners
| - [ ] .devcontainer.json configuration install latest `azd` version | ||
| - [ ] Infrastructure as code is in place (`/infra` folder where applicable, manifest files or code generators in the case of `Aspire` and similar ) | ||
| - [ ] Azure services configuration (/azure.yml file) is in place | ||
| - [ ] `remoteBuild` is set to `true` to enable cross-platform support, in the [template configuration](https://github.com/Azure-Samples/azd-template-artifacts/blob/main/docs/development-guidelines/template-configuration.md) |
Collaborator
There was a problem hiding this comment.
Should this be configured in the devcontainer.json or in the azure.yaml file? The link goes to the dev container but I think this should be link to https://github.com/Azure-Samples/azd-ai-starter/blob/main/azure.yaml
Maybe I'm missing something?
| - [ ] DevContainer has been tested locally and runs | ||
| - [ ] Codespaces run [locally and in browser] | ||
| - [ ] All tests pass | ||
| - [ ] Playwright e2e tests are in place, to test the application has been successfully deployed, and all tests pass |
Collaborator
There was a problem hiding this comment.
Does it have to be Playwright? Or could the author use a different testing framework?
kristenwomack
approved these changes
Jan 15, 2025
Collaborator
kristenwomack
left a comment
kristenwomack
left a comment
There was a problem hiding this comment.
Left a few clarifying comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information