feat: Supportability for planOnly mode
#325
Conversation
jaredfholgate
left a comment
jaredfholgate
left a comment
There was a problem hiding this comment.
Although this may be a useful feature, it doesn't actually help with the original issue I'm afraid. This is very likely because I did not explain it properly.
The place we need the plan only options is here: https://github.com/Azure/accelerator-bootstrap-modules/blob/d955b911ff469c14a99e783eccbd75c1ac94b69b/.github/workflows/end-to-end-test.yml#L335
We basically just need to skip the CD part:
- https://github.com/Azure/accelerator-bootstrap-modules/blob/d955b911ff469c14a99e783eccbd75c1ac94b69b/.github/workflows/end-to-end-test.yml#L356
- https://github.com/Azure/accelerator-bootstrap-modules/blob/d955b911ff469c14a99e783eccbd75c1ac94b69b/.github/workflows/end-to-end-test.yml#L377
Add a planOnly flag to the matrix here to support it: https://github.com/Azure/accelerator-bootstrap-modules/blob/d955b911ff469c14a99e783eccbd75c1ac94b69b/.github/tests/scripts/generate-matrix.ps1#L5
| if(!$autoApprove) { | ||
| if($planOnly) { | ||
| return | ||
| } elseif(!$autoApprove) { |
There was a problem hiding this comment.
Can we just make the a second if statement for readability since the two options are not directly related?
| } elseif(!$autoApprove) { | |
| } | |
| if(!$autoApprove) { |
|
I'm going to close this. Thanks for doing the work and apologies for abandoning it! |
Pull Request
Issue
Azure/Azure-Landing-Zones#403
Description
Description of changes:
planOnlyattribuite toDeploy-Accelerator.ps1planOnlyswitch inNew-Bootstrap.ps1planOnlyswitch inInvoke-Terraform.ps1License
By submitting this pull request, I confirm that my contribution is made under the terms of the projects associated license.