test: remove undeployed alert cases - #6427
Conversation
These rules have not been generated or deployed since PR Azure#5915 disabled them pending rework. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e5934ae5-5f36-4edd-aa01-9dee35f0b13b
Drop vacuous negative cases for alerts that are not part of the generated Azure alert deployment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: e5934ae5-5f36-4edd-aa01-9dee35f0b13b
There was a problem hiding this comment.
🟢 Ready to approve
The changes are limited to removing obsolete/orphaned test cases and do not alter generated or deployed alerting behavior.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Pull request overview
This PR cleans up Prometheus rule unit tests to match the alert rules that are actually generated/deployed, removing orphaned or no-op test coverage left behind after prior alert deployment changes (notably #5915).
Changes:
- Removes five negative
exp_alerts: []test cases that correspond to alerts not present in the generated Azure Prometheus alert rule deployments. - Deletes the Cluster Service SLO promtool test suite that remained after the Cluster Service SLO alert deployment was disabled.
File summaries
| File | Description |
|---|---|
| observability/alerts/prometheus-prometheusRule_test.yaml | Drops orphaned/vacuous promtool test cases for alerts not part of generated Azure alert deployments. |
| cluster-service/alerts/cluster-service-slo-rules_test.yaml | Removes the now-orphaned Cluster Service SLO promtool test suite after the related deployment was disabled. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmazur, roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What
Why
The Cluster Service alert deployment was disabled pending rework in #5915, but its tests remained. The Prometheus suite also retained five
exp_alerts: []cases for alerts that are not operationally deployed. Removing these cases keeps test coverage aligned with the alert rules we actually generate and deploy.No separate tracking ticket exists; this is follow-up cleanup for PR #5915.
Testing
make -C tooling/prometheus-rules run-sl-servicesalertnameunder*_test.yamlexists in generated alert deployments; only the intentionalInstancesDownV1tooling fixture is excluded.Special notes for your reviewer
Screenshots are not applicable because this removes tests only and does not change deployed alerting behavior.
PR Checklist