test: extend aggregated features test case

[Miquel Simon (miquelsi)]

https://redhat.atlassian.net/browse/ARO-27357

What

Extend current feature aggregation test case with:

• Node pool autoscaling
• Node labels & taints
• Image Digest Mirrors (IMDS)

Why

Testing

Testing is required for feature completion and tests should be part of the pull
request along with the feature changes.

Describe the testing provided. If you did not add tests, provide a clear
justification.

• Unit tests
• Integration tests
• E2E tests

Special notes for your reviewer

PR Checklist

• PR is scoped to a single task (no mixed concerns)
• Title follows Conventional Commits format
• Summary explains the "Why" behind the change
• Linked to relevant ticket/issue
• Screenshots included (if graph/UI/metrics changes)
• Self-reviewed the diff
• CI/CD checks are passing (ignore Tide)
• Draft PR used for WIP (if applicable)
• Commit history is clean (rebased/squashed)
• Tricky code blocks are commented
• Specific reviewers tagged
• All comment threads resolved before merge

If E2E tests are included:

• E2E tests follow Principles of Good E2E Test Case Design
• If new E2E use case is covered (via a new test or new check/verifier),
  demonstrate that the test is able to detect a defect/error and fail with
  proper error message and logs which communicates nature of the problem.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: miquelsi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [miquelsi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Extends the existing aggregated “advanced features” E2E scenario to cover additional cluster and node pool capabilities against the v20251223preview API surface, ensuring these features can be created and validated end-to-end.

Changes:

• Add NodePool Labels and Taints support to the v20251223preview test framework helpers and plumb them into node pool create payloads.
• Extend the feature aggregation E2E to configure and validate Image Digest Mirrors (IDMS) on the cluster.
• Extend the same E2E to create an autoscaling node pool and validate node pool autoscaling + label/taint propagation onto Kubernetes Nodes.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
test/util/framework/helpers_v20251223preview.go	Adds node pool label/taint params and includes them in the v20251223preview node pool payload builder.
test/e2e/cluster_create_feature_aggregation.go	Expands the aggregated-features E2E to cover IDMS, node pool autoscaling, and node pool labels/taints (including node-level verification).

[Copilot]

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Suppressed comments (1)

test/e2e/cluster_create_feature_aggregation.go:462

• The comment claims VerifyNodesReady only checks that "some" nodes are Ready, but the verifier actually fails if any node is NotReady (it iterates all nodes and errors if any are not ready). This makes the comment misleading and could confuse future edits to this polling logic.

			// VerifyNodesReady only asserts that some nodes are Ready; poll until the
			// autoscaling min and the specialized np-b replica have joined with the
			// expected labels/taints before continuing.

[openshift-ci]

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.