feature: adding subscription key for quotaizer msi

[Rachel Weber (rachelvweber)]

ARO-28898

What

Adding a subscription key for the quotaizer msi

Why

This MSI is shared across environments, but it should be separate for stg and production. Because the global subscription key in stg is still pointing to the global production subscription, adding a field here that I can overwrite in stg. Without this, the deployment pipeline is quite messy.

Testing

N/A just adding a field to config.

Special notes for your reviewer

PR Checklist

• PR is scoped to a single task (no mixed concerns)
• Title follows Conventional Commits format
• Summary explains the "Why" behind the change
• Linked to relevant ticket/issue
• Screenshots included (if graph/UI/metrics changes)
• Self-reviewed the diff
• CI/CD checks are passing (ignore Tide)
• Draft PR used for WIP (if applicable)
• Commit history is clean (rebased/squashed)
• Tricky code blocks are commented
• Specific reviewers tagged
• All comment threads resolved before merge

If E2E tests are included:

• E2E tests follow Principles of Good E2E Test Case Design
• If new E2E use case is covered (via a new test or new check/verifier),
  demonstrate that the test is able to detect a defect/error and fail with
  proper error message and logs which communicates nature of the problem.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rachelvweber
Once this PR has been reviewed and has the lgtm label, please assign mmazur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• config/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Copilot]

Pull request overview

Adds a new quotaizer.managedIdentitySubscriptionKey config field (defaulting to hcp-global) so the quotaizer managed identity’s subscription can be overridden (e.g., in MSFT stg) without having to restructure deployment pipelines.

Changes:

• Introduce defaults.quotaizer.managedIdentitySubscriptionKey in config/config.yaml.
• Extend config/config.schema.json to allow the new quotaizer field.
• Regenerate rendered dev configs to include the new field.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
config/config.yaml	Adds the new quotaizer default managedIdentitySubscriptionKey.
config/config.schema.json	Adds schema property for quotaizer.managedIdentitySubscriptionKey (description updated needed per comment).
config/rendered/dev/pers/westus3.yaml	Materialized output includes the new quotaizer field.
config/rendered/dev/perf/westus3.yaml	Materialized output includes the new quotaizer field.
config/rendered/dev/dev/westus3.yaml	Materialized output includes the new quotaizer field.
config/rendered/dev/cspr/westus3.yaml	Materialized output includes the new quotaizer field.
config/rendered/dev/ci01/centralus.yaml	Materialized output includes the new quotaizer field.
config/rendered/dev/ci00/centralus.yaml	Materialized output includes the new quotaizer field.

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (1)

config/config.schema.json:3179

• The schema description for managedIdentitySubscriptionKey looks inconsistent with the surrounding quotaizer config (it mentions "the refresher"), which can mislead readers about what this key is for. Consider updating the description to explicitly reference the quotaizer managed identity/subscription key purpose.

        "managedIdentitySubscriptionKey": {
          "type": "string",
          "description": "The ev2 subscription key for the MSI that will be used by quotaizer"
        },

[Copilot]

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated no new comments.

Suppressed comments (1)

config/config.yaml:467

• PR title uses the non-standard Conventional Commits type feature:. CONTRIBUTING.md requires standard prefixes like feat:, fix:, docs:, etc.; please rename the PR title accordingly (the checklist currently claims the title follows Conventional Commits).

    # This should be removed and replaced with global.subscription.key in quotaizer deployment pipeline once old stg infra is decommissioned (AROSLSRE-1202)
    managedIdentitySubscriptionKey: "hcp-global"