feat: add required useGlobalMeterIds flag to billing config - #6465
feat: add required useGlobalMeterIds flag to billing config#6465Abby Duke (abiduke612) wants to merge 1 commit into
Conversation
|
/lgtm |
c9d23c5 to
c724e06
Compare
|
/lgtm |
There was a problem hiding this comment.
Pull request overview
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Adds a new required useGlobalMeterIds boolean flag to the billing config to support an upcoming migration to global meters for HCP billing.
Changes:
- Add
billing.useGlobalMeterIdsdefault value toconfig/config.yaml. - Extend
config/config.schema.jsonto define and requirebilling.useGlobalMeterIds. - Populate
useGlobalMeterIds: falsein several rendered dev configs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| config/rendered/dev/pers/westus3.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/rendered/dev/perf/westus3.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/rendered/dev/dev/westus3.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/rendered/dev/cspr/westus3.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/rendered/dev/ci01/centralus.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/rendered/dev/ci00/centralus.yaml | Adds billing.useGlobalMeterIds: false to rendered dev config. |
| config/config.yaml | Introduces the default value for the new flag under billing defaults. |
| config/config.schema.json | Adds schema definition + marks the flag as required in billing config. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abiduke612, rachelvweber, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
https://redhat.atlassian.net/browse/ARO-28647
What
Add
useGlobalMeterIdsflag to config to set us up to migrate to using global meters for HCP billing