Skip to content

feat: add required useGlobalMeterIds flag to billing config - #6465

Open
Abby Duke (abiduke612) wants to merge 1 commit into
Azure:mainfrom
abiduke612:abbyduke/create-billing-globalmeterid-flag
Open

feat: add required useGlobalMeterIds flag to billing config#6465
Abby Duke (abiduke612) wants to merge 1 commit into
Azure:mainfrom
abiduke612:abbyduke/create-billing-globalmeterid-flag

Conversation

@abiduke612

Copy link
Copy Markdown
Collaborator

https://redhat.atlassian.net/browse/ARO-28647

What

Add useGlobalMeterIds flag to config to set us up to migrate to using global meters for HCP billing

Copilot AI lite review requested due to automatic review settings August 6, 2026 18:51
@rachelvweber

Copy link
Copy Markdown
Collaborator

/lgtm

@abiduke612
Abby Duke (abiduke612) force-pushed the abbyduke/create-billing-globalmeterid-flag branch from c9d23c5 to c724e06 Compare August 6, 2026 19:16
@openshift-ci openshift-ci Bot removed the lgtm label Aug 6, 2026
@rachelvweber

Copy link
Copy Markdown
Collaborator

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Aug 6, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Adds a new required useGlobalMeterIds boolean flag to the billing config to support an upcoming migration to global meters for HCP billing.

Changes:

  • Add billing.useGlobalMeterIds default value to config/config.yaml.
  • Extend config/config.schema.json to define and require billing.useGlobalMeterIds.
  • Populate useGlobalMeterIds: false in several rendered dev configs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
config/rendered/dev/pers/westus3.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/rendered/dev/perf/westus3.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/rendered/dev/dev/westus3.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/rendered/dev/cspr/westus3.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/rendered/dev/ci01/centralus.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/rendered/dev/ci00/centralus.yaml Adds billing.useGlobalMeterIds: false to rendered dev config.
config/config.yaml Introduces the default value for the new flag under billing defaults.
config/config.schema.json Adds schema definition + marks the flag as required in billing config.

Comment thread config/config.schema.json
Comment thread config/rendered/dev/pers/westus3.yaml
Copilot AI review requested due to automatic review settings August 6, 2026 19:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@stevekuznetsov

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abiduke612, rachelvweber, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants