fix: use explicit Clusters Service ARM helper config - #6478
Draft
roi (roivaz) wants to merge 2 commits into
Draft
Conversation
Pass shared and dedicated ARM-helper values independently through EV2, then select the dedicated pair from the Helm chart only when both values are present. This keeps INT on the shared identity until its dedicated values are configured and avoids resolve-mode placeholder truthiness. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Skipping CI for Draft Pull Request. |
Have the Cluster Service chart consume only clustersServiceArmHelperClientId and clustersServiceArmHelperCertName. Environments without a dedicated identity must populate those fields with the shared identity; single-lease CI now does so explicitly. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roivaz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redhat.atlassian.net/browse/AROSLSRE-1776
What
Make the Clusters Service chart consume only
clustersServiceArmHelperClientIdandclustersServiceArmHelperCertName. The chart no longer reads the BackendarmHelperClientIdorarmHelperCertNamefields and contains no identity fallback logic.Configuration owns identity sharing explicitly:
Focused Helm fixtures cover shared and distinct identity configurations.
Why
The original split in #6454 performed fallback in preprocessed
cluster-service/values.yaml. In EV2 resolve mode, the dedicated references became non-empty__...__placeholders, so the conditional selected them before EV2 substituted INT's real empty values. Helm received empty helper fields, omitted the ARM-helper flags and certificate mount, and Clusters Service fell back to the mock FPA for CheckAccess V2.#6476 restored the shared identity as an incident mitigation. Keeping environment migration policy out of the chart makes the re-land simpler and removes the entire placeholder/fallback failure class: Clusters Service has one explicit configuration pair, and each environment decides which identity populates it.
openshift/release PR #83084 remains on hold until this chart support is ready.
Testing
make verify-materializehack/ci/build-config-override.shcheck-ev2-rendersemantic guardMicrosoft.Azure.ARO.HCP.ClusterServiceSpecial notes for your reviewer
The large generated portion consists of the two standard Helm fixtures. The dedicated identity infrastructure and configuration fields introduced by #6454 remain unchanged.
PR Checklist