Skip to content

chore: remove static role assignment quota config - #6505

Draft
roi (roivaz) wants to merge 2 commits into
Azure:mainfrom
roivaz:dynamic-role-assignment-quota-config
Draft

chore: remove static role assignment quota config#6505
roi (roivaz) wants to merge 2 commits into
Azure:mainfrom
roivaz:dynamic-role-assignment-quota-config

Conversation

@roivaz

@roivaz roi (roivaz) commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Tracking: https://redhat.atlassian.net/browse/AROSLSRE-1789

What

  • Remove roleAssignmentLimit from DEV CI source configuration and schema.
  • Stop rendering the legacy field into Helm values and the exporter ConfigMap.

Why

The API-backed exporter introduced by #6494 no longer consumes a static role-assignment limit. Removing the field avoids stale duplicated quota data.

Rollout dependency: do not merge this PR until #6494 is merged, the tenant-quota-collector image is built, the image-updater has merged the new digest into config/config-dev-ci.yaml, and that image is deployed. The currently deployed binary defaults a missing limit to 4000, which would report incorrect limits for subscriptions configured at 8000.

Testing

  • make -C config materialize
  • make verify-schema
  • make -C tooling/tenant-quota render-config
  • confirmed rendered runtime config contains no roleAssignmentLimit

Special notes for your reviewer

Blocked on the code/image rollout from #6494. No reviewers have been requested or tagged; this draft is intentionally waiting for author review first.

Screenshots are not applicable because this only removes an obsolete configuration field and does not change metric names, labels, or visualizations.

PR Checklist

  • PR is scoped to a single task (no mixed concerns)
  • Title follows Conventional Commits format
  • Summary explains the "Why" behind the change
  • Linked to relevant ticket/issue
  • Screenshots included (if graph/UI/metrics changes) — not applicable; no visualization change
  • Self-reviewed the diff
  • CI/CD checks are passing (ignore Tide) — pending draft PR CI
  • Draft PR used for WIP (if applicable)
  • Commit history is clean (rebased/squashed)
  • Tricky code blocks are commented
  • Specific reviewers tagged — intentionally deferred until author review
  • All comment threads resolved before merge

Remove roleAssignmentLimit only after the API-backed exporter image is deployed, preventing the old image from falling back to 4000 for subscriptions with increased quotas.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Remove the duplicated onboarding documentation change from the configuration cleanup PR.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roivaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant