-
Notifications
You must be signed in to change notification settings - Fork 258
feat(rcv1p): unify cert bootstrap flow and add Windows CA refresh task #8096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
0e25cf3
97de410
b2e72ac
b9fcd6f
9a9c5ee
6cced51
5b553ca
e2bc72b
ad01392
e649f3e
b12fb1e
49b2e6e
4929b0c
e485641
6b468ea
c026af5
ee24a23
1f0fc8e
8d17c7c
8b65cc8
dbc0a28
266f9d5
3907efb
2e8b811
77245c4
d88d517
2ad18c7
d6a151e
eaaac9b
e85af60
395766a
6116cc5
d71b6cd
0c1587d
2c02745
0c5e3e1
69a5d18
8df18ae
1ae597b
e15d8ca
4d5ca4e
b936a2f
15c0077
2efa0f2
ce1a29f
fcc42a9
d37eeae
5ff8a25
dfb2c10
8c89063
4ada2fe
cf07a71
09b8d20
b99bede
cafa6ec
00804a3
5904637
c709eae
e1959ba
dee66b3
117adaa
2cb6a99
ccc57f8
1efb2c0
d1414df
224576e
f757ce8
796d1ff
482ec2d
3c0baac
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| name: $(Date:yyyyMMdd)$(Rev:.r) | ||
| variables: | ||
| TAGS_TO_RUN: "rcv1pcertmode=true" | ||
| SKIP_E2E_TESTS: false | ||
| E2E_GO_TEST_TIMEOUT: "75m" | ||
| schedules: | ||
| - cron: "0 11 * * *" | ||
| displayName: Daily 3am PST | ||
| branches: | ||
| include: | ||
| - main | ||
| always: true | ||
| trigger: none | ||
| pr: none | ||
| jobs: | ||
| - template: ./templates/e2e-template.yaml | ||
| parameters: | ||
| name: RCV1P Cert Mode Tests | ||
| IgnoreScenariosWithMissingVhd: false | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -38,6 +38,7 @@ jobs: | |
| displayName: Run AgentBaker E2E | ||
| env: | ||
| E2E_SUBSCRIPTION_ID: $(E2E_SUBSCRIPTION_ID) | ||
| RCV1P_SUBSCRIPTION_ID: $(RCV1P_SUBSCRIPTION_ID) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. did you inject this into the RCV1P E2E pipeline variables directly?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct, and relevant only for TME tenant since MSFT tenant's E2E_SUBSCRIPTION_ID already exercises rcv1p path. In my test, RCV1P_SUBSCRIPTION_ID was set to a different value and models a customer who can opt-in their subscription for rcv1p. |
||
| SYS_SSH_PUBLIC_KEY: $(SYS_SSH_PUBLIC_KEY) | ||
| SYS_SSH_PRIVATE_KEY_B64: $(SYS_SSH_PRIVATE_KEY_B64) | ||
| BUILD_SRC_DIR: $(System.DefaultWorkingDirectory) | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| echo $(date),$(hostname) > ${PROVISION_OUTPUT}; | ||
| {{if getIsAksCustomCloud .CustomCloudConfig}} | ||
| REPO_DEPOT_ENDPOINT="{{.CustomCloudConfig.RepoDepotEndpoint}}" | ||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
| {{end}} | ||
| LOCATION="{{getCloudLocation .}}" | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
|
||
| {{getInitAKSCustomCloudFilepath}} >> /var/log/azure/cluster-provision.log 2>&1; | ||
|
rchincha marked this conversation as resolved.
rchincha marked this conversation as resolved.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we should change the name of this template func: maybe
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was planning a follow up PR that cleans up references to "custom" after this PR lands. Also see my comment below. But ok either way. |
||
| /usr/bin/nohup /bin/bash -c "/bin/bash /opt/azure/containers/provision_start.sh" | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is going to monitor this pipeline and address any issues?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably include an explicit run of this pipeline within our daily build system we use for official releases, that way we're guaranteed to have visibility during official release flows
though at the end of the day it's going to be on us to deal with failures
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be enabled in the TME tenant and probably as a async nightly so that it doesn't interfere with "immediate" tests (PRs, etc)