chore: remove windows annual VHD build inputs#8540
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes Windows Server 23H2 (“Windows Annual”) VHD build inputs from the Windows VHD builder configuration and Azure DevOps pipelines, and introduces a validation guard to prevent those retired inputs from being reintroduced.
Changes:
- Removed WS23H2 base version entries and WS23H2-specific registry key overrides from
windows_settings.json. - Removed WS23H2-specific cached component entries from
parts/common/components.json. - Removed WS23H2 build parameters/stages from Windows PR/release pipelines and added a validation stage that enforces the retirement policy.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
vhdbuilder/packer/windows/windows_settings.json |
Drops WS23H2 base image definitions and WS23H2-specific registry key overrides. |
parts/common/components.json |
Removes WS23H2-specific cached container/OCI entries. |
.pipelines/templates/.build-and-test-windows-vhds-template.yaml |
Removes WS23H2 build parameters/stages; adds a config validation stage. |
.pipelines/scripts/validate-no-windows-annual-vhd-build.sh |
New guard script that fails builds if WS23H2 build inputs/tokens are detected in key configs/pipelines. |
.pipelines/.vsts-vhd-builder-release-windows.yaml |
Removes WS23H2 parameters wiring into the shared build template. |
.pipelines/.vsts-vhd-builder-pr-windows.yaml |
Removes WS23H2 as a default PR-build target. |
|
@microsoft-github-policy-service agree company="Microsoft" |
1a3c0da to
cb17d5d
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…' into abdulasfari/remove-wsannual-vhds
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
cb17d5d to
028c725
Compare
| @@ -0,0 +1,60 @@ | |||
| #!/usr/bin/env bash | |||
| set -euo pipefail | |||
There was a problem hiding this comment.
You can remove this file - no need to a test that we don't produce it anymore! The rest of the PR is good.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
.pipelines/templates/.build-and-test-windows-vhds-template.yaml:13
- PR description/validation references
bash .pipelines/scripts/validate-no-windows-annual-vhd-build.sh, but that script is not present in the repo and this template does not run such a guard step. Either add the missing script and invoke it early in the pipeline (e.g., before VHD build stages), or update the PR description/validation steps so they match what’s actually in-tree.
parameters:
- name: build2022containerd
displayName: Build 2022 containerd
type: boolean
- name: build2022containerdgen2
displayName: Build 2022 containerd Gen 2
type: boolean
- name: build2025
displayName: Build 2025
type: boolean
- name: build2025gen2
displayName: Build 2025 Gen 2
type: boolean
Summary
Validation