Skip to content

Conversation

@jfaurskov
Copy link
Collaborator

@jfaurskov jfaurskov commented Nov 27, 2025

This PR includes the count of individual SKUs collected in the reporting.

  • Update Get-AzureServices.ps1 to include sku count per SKU
  • Update Get-AvailabilityInformation.ps1 to handle expanded input (count) from collection process
  • Update Get-AvailabilityInformation.ps1 to accept file paths for summary file
  • Update Get-Report.ps1 to include sku count in report

Copilot AI review requested due to automatic review settings November 27, 2025 09:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Azure resource reporting system by adding SKU count tracking throughout the collection, availability checking, and reporting pipeline.

Key changes:

  • Modified SKU collection to group and count unique SKUs per resource type
  • Updated object comparison logic to exclude the new "count" property when comparing SKUs
  • Enhanced report generation to display SKU counts alongside other resource metrics

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
1-Collect/Get-AzureServices.ps1 Implements SKU grouping and counting logic using ConvertTo-Json for unique identification, adds "count" property to each SKU object
2-AvailabilityCheck/Get-AvailabilityInformation.ps1 Updates Compare-ObjectsStrict function to exclude "count" property from comparison logic while maintaining SKU identity matching
7-Report/Get-Report.ps1 Adds skuCount parameter to Set-SvcAvailReportObj function and includes SKU count in report data for all code paths

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

jfaurskov and others added 4 commits November 27, 2025 10:56
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@jfaurskov jfaurskov requested a review from lvlindv November 27, 2025 10:07
Copy link
Collaborator

@lvlindv lvlindv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and works as expected

@lvlindv lvlindv merged commit f46937f into main Dec 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants