-
Notifications
You must be signed in to change notification settings - Fork 10
Include SKU count #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the Azure resource reporting system by adding SKU count tracking throughout the collection, availability checking, and reporting pipeline.
Key changes:
- Modified SKU collection to group and count unique SKUs per resource type
- Updated object comparison logic to exclude the new "count" property when comparing SKUs
- Enhanced report generation to display SKU counts alongside other resource metrics
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| 1-Collect/Get-AzureServices.ps1 | Implements SKU grouping and counting logic using ConvertTo-Json for unique identification, adds "count" property to each SKU object |
| 2-AvailabilityCheck/Get-AvailabilityInformation.ps1 | Updates Compare-ObjectsStrict function to exclude "count" property from comparison logic while maintaining SKU identity matching |
| 7-Report/Get-Report.ps1 | Adds skuCount parameter to Set-SvcAvailReportObj function and includes SKU count in report data for all code paths |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…Selection into include-sku-count
lvlindv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and works as expected
This PR includes the count of individual SKUs collected in the reporting.