fix(mcp): Adding custom date time picker for generate keys and minor bug fixes#8793
Merged
preetriti1 merged 4 commits intomainfrom Feb 5, 2026
Merged
fix(mcp): Adding custom date time picker for generate keys and minor bug fixes#8793preetriti1 merged 4 commits intomainfrom
preetriti1 merged 4 commits intomainfrom
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Title is clear; optional slight wording improvement suggested. |
| Commit Type | ✅ | Correctly set to fix. |
| Risk Level | Change label to risk:medium or justify why low is accurate given lockfile/dependency changes. |
|
| What & Why | ✅ | Good; optionally tie to specific files/components. |
| Impact of Change | Expand to call out added dependencies and lockfile changes and their potential impact. | |
| Test Plan | ✅ | Unit tests present; note missing E2E — justify or add if needed. |
| Contributors | ✅ | OK — include more names if applicable. |
| Screenshots/Videos | ✅ | Screenshot included. |
Summary & Actions
- Advised risk level: medium — this is higher than the PR's selected
Low. Please update the PR label torisk:mediumor add an explicit explanation in the PR body and/or a checklist showing why the dependency and pnpm-lock changes are safe (e.g., results of CI, staging run, compatibility verification, bundle size check). - Please expand the Impact of Change section to explicitly call out the new packages and the pnpm-lock changes and any testing you ran to validate cross-package compatibility.
- If E2E tests are not added, add a short sentence explaining why they are unnecessary for this change or plan for an E2E test / integration test to be added in a follow-up PR.
- Ensure the CI runs (build + tests) pass with the updated lockfile and new dependencies. If you have validated those, add a short line in the Test Plan: e.g., "CI: build and unit tests passed on branch ".
Please update the PR body/labels accordingly and re-submit or leave a comment linking to the verification you performed. Thank you for the thorough PR and the added tests — they help a lot in review!
Last updated: Thu, 05 Feb 2026 10:00:49 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a custom date-time picker for MCP API key expiration, fixes workflow name casing when creating/updating MCP servers, and enables the collapsible property on the servers accordion.
Changes:
- Added custom date-time picker with new Fluent UI dependencies (
@fluentui/react-datepicker-compatand@fluentui/react-timepicker-compat) allowing users to specify a custom expiration date/time for API keys - Fixed workflow name casing preservation by mapping selected lowercase workflow values back to their original cased labels when creating/updating servers
- Added
collapsible={true}property to the MCP servers accordion to allow users to collapse all server sections
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/designer/src/lib/ui/mcp/servers/servers.tsx | Added collapsible property to Accordion component for better UX |
| libs/designer/src/lib/ui/mcp/panel/styles.ts | Added styles for date-time picker container and time picker component |
| libs/designer/src/lib/ui/mcp/panel/server/generatekeys.tsx | Implemented custom date-time picker component with manual time parsing, added "Custom" duration option, and integrated with key generation flow |
| libs/designer/src/lib/ui/mcp/panel/server/create.tsx | Fixed workflow name casing by looking up original cased labels from workflowOptions when submitting server tools |
| libs/designer/src/lib/ui/mcp/panel/server/test/generatekeys.spec.tsx | Added comprehensive unit tests for custom date-time picker component covering various time formats and user interactions |
| libs/designer/src/lib/ui/mcp/panel/server/test/create.spec.tsx | Updated test expectations to reflect tools as array format with proper casing |
| libs/designer/package.json | Added Fluent UI date picker and time picker dependencies |
| apps/Standalone/package.json | Added Fluent UI date picker and time picker dependencies for standalone app |
| Localize/lang/strings.json | Added localization strings for custom date-time picker UI elements |
libs/designer/src/lib/ui/mcp/panel/server/__test__/generatekeys.spec.tsx
Show resolved
Hide resolved
This was
linked to
issues
Feb 5, 2026
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
rllyy97
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Adding custom date time picker option while regenerating MCP API Keys.
Retaining casing of workflow names while creating new MCP server with existing workflows.
enabling option in accordian so all options can be collapsed.
Impact of Change
Test Plan
Contributors
@kewear @bonicaayala
Screenshots/Videos