FIX: set virtual env in docker dev setup #1281
Merged
+22
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahwestra25
changed the title
romanlutz
approved these changes
Dec 23, 2025
romanlutz
approved these changes
Dec 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR re-uses the environment that is created by the base image (opt/venv) and while giving it the alias pyrit-dev so that in the terminal the environment shows as (pyrit-dev). It also removes the previous hashing logic and stores the hash in the envionment explicitly rather than the shared volume cache.
What was previously happening:
Create container → Install packages → Save hash to volume
Delete container → Hash persists on volume, but venv is gone
Create new container → Hash matches, setup script skips installation → No packages!
also, uses the active environment when running the makefile so make works locally and in our pipelines
Tests and Documentation