MAINT: Enhance type hinting across auth and analytics modules #1300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added type hints to various functions in auth and analytics. And added explicit cast to satisfy mypy.
#1272
@romanlutz
The only thing I think requires further notice is
cosine_similarityfunction in pyrit/analytics/conversation_analytics.py The type hint was this to return a np.ndarry. I looked into the reference the inputs are always 1D arrays so the return type is float. Let me know what do you think. Thanks.Tests and Documentation
The changes passed the
pre-commit run mypy --files pyrit/auth/*.pyandpre-commit run mypy --files pyrit/analytics/*.pywith
--strictin pre-commit args.