fix: make nil report as no error & add test for duplicate version. #226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #225 to enable CI/CD checks with required secrets.
Original PR by @kewalaka
This pull request improves error handling and test coverage for the
addPolicyAndRoleAssetsmethod inalzlib.go, ensuring that duplicate policy and policy set definition versions are handled correctly. The changes refactor how errors are accumulated and reported, and add targeted unit tests for duplicate version scenarios.Error handling improvements:
addPolicyAndRoleAssetsto usemultierror.Appendfor both policy definitions and policy set definitions, ensuring errors are wrapped with descriptive context and reported correctly.Testing enhancements:
TestAddPolicyAndRoleAssetsAllowsDuplicateVersionsunit test to verify that adding duplicate versions of policy and policy set definitions works as expected, both when overwriting is allowed and disallowed.testPolicyDefinitionandtestPolicySetDefinitionto simplify test setup for policy assets.fixes: Azure/terraform-provider-alz#188
& Azure/terraform-provider-alz#189