fix: policy role assignment #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests for PolicyRoleAssignments func covering: - Valid role assignments returned even when PolicyRoleAssignmentErrors occurs - All role assignments returned when no errors occur - Non-PolicyRoleAssignmentErrors error returns nil results
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #234 +/- ##
==========================================
+ Coverage 50.52% 51.99% +1.46%
==========================================
Files 49 49
Lines 3968 3964 -4
==========================================
+ Hits 2005 2061 +56
+ Misses 1701 1645 -56
+ Partials 262 258 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jtracey93
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and test coverage of policy role assignment generation in the deployment hierarchy. The main changes involve better error handling to ensure that valid role assignments are still returned even when some errors occur, and the addition of comprehensive tests to verify this behavior.
Error Handling Improvements:
Hierarchy.PolicyRoleAssignmentsto accumulatePolicyRoleAssignmentErrorsand continue processing, but to immediately return on non-PolicyRoleAssignmentErrors, ensuring partial results are only returned for known, aggregatable errors.HierarchyManagementGroup.generatePolicyAssignmentAdditionalRoleAssignmentsto skip policy definitions with no role definition IDs instead of returning an error, preventing unnecessary failures and allowing processing to continue. [1] [2]Testing Enhancements:
hierarchy_test.goforPolicyRoleAssignments, covering scenarios with partial errors, all-success cases, and non-aggregatable errors, ensuring correct behavior and error reporting in all situations.fixes Azure/Azure-Landing-Zones#3973