Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Jan 28, 2026

Fix incorrect wording for Virtual Network Gateway availability zones recommendation

Issue

The recommendation for vgw-005 incorrectly says "Storage should have availability zones enabled" instead of "Virtual Network Gateway should have availability zones enabled"

Changes Made

  • Updated recommendation text in /internal/scanners/vgw/rules.go from "Storage should have availability zones enabled" to "Virtual Network Gateway should have availability zones enabled" (singular form for consistency)
  • Regenerated /data/recommendations.json to reflect the change
  • Reverted unintended changes to docs/go.mod and docs/go.sum
  • All tests passing

Files Changed (Final)

  • internal/scanners/vgw/rules.go - Fixed recommendation text
  • data/recommendations.json - Regenerated from source
Original prompt

This section details on the original issue you should resolve

<issue_title>Incorrect wording for Recommendation for Microsoft.Network/virtualNetworkGateways</issue_title>
<issue_description>## Expected Behavior
Under "ImpactedResources"

Category : HighAvailability
Impact:High
Resource Type:Microsoft.Network/virtualNetworkGateways
Recommendation: Virtual Network Gateways should have availability zones enabled
Learn : https://learn.microsoft.com/en-us/azure/vpn-gateway/create-zone-redundant-vnet-gateway

Actual Behavior

Under "ImpactedResources"

Category : HighAvailability
Impact:High
Resource Type:Microsoft.Network/virtualNetworkGateways
Recommendation: Storage should have availability zones enabled

Wording for the "Recommendation" is incorrect. It should not say storage. it should say "virtual network gateway"

Image

Steps to Reproduce the Problem

run the azqr export and just view the report

run the azqr export and just view the report

</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits January 28, 2026 07:59
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix incorrect wording for virtual network gateway recommendation Fix incorrect recommendation text for Virtual Network Gateway availability zones Jan 28, 2026
Copilot AI requested a review from cmendible January 28, 2026 08:05
Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the changes only for the json and the rules.go file

Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jan 28, 2026

Keep the changes only for the json and the rules.go file

Done. Reverted changes to docs/go.mod and docs/go.sum in commit 33e6823. The PR now only contains changes to internal/scanners/vgw/rules.go and data/recommendations.json.

Copilot AI requested a review from cmendible January 28, 2026 08:18
@cmendible cmendible marked this pull request as ready for review January 28, 2026 08:31
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 35.99%. Comparing base (44a2daa) to head (33e6823).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #735   +/-   ##
=======================================
  Coverage   35.99%   35.99%           
=======================================
  Files         269      269           
  Lines        9981     9981           
=======================================
  Hits         3593     3593           
  Misses       6268     6268           
  Partials      120      120           
Flag Coverage Δ
unittests 35.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@cmendible cmendible left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmendible cmendible merged commit 2518603 into main Jan 29, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect wording for Recommendation for Microsoft.Network/virtualNetworkGateways

3 participants