-
Notifications
You must be signed in to change notification settings - Fork 129
Fix incorrect recommendation text for Virtual Network Gateway availability zones #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
cmendible
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep the changes only for the json and the rules.go file
Co-authored-by: cmendible <266546+cmendible@users.noreply.github.com>
Done. Reverted changes to docs/go.mod and docs/go.sum in commit 33e6823. The PR now only contains changes to internal/scanners/vgw/rules.go and data/recommendations.json. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #735 +/- ##
=======================================
Coverage 35.99% 35.99%
=======================================
Files 269 269
Lines 9981 9981
=======================================
Hits 3593 3593
Misses 6268 6268
Partials 120 120
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmendible
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix incorrect wording for Virtual Network Gateway availability zones recommendation
Issue
The recommendation for
vgw-005incorrectly says "Storage should have availability zones enabled" instead of "Virtual Network Gateway should have availability zones enabled"Changes Made
/internal/scanners/vgw/rules.gofrom "Storage should have availability zones enabled" to "Virtual Network Gateway should have availability zones enabled" (singular form for consistency)/data/recommendations.jsonto reflect the changedocs/go.modanddocs/go.sumFiles Changed (Final)
internal/scanners/vgw/rules.go- Fixed recommendation textdata/recommendations.json- Regenerated from sourceOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.