res mode: Fix a bug that some resource types are not exported when --include-role-assignment is specified
#641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`--include-role-assignment` is specified Previously, when `--include-role-assignment` is specified, the resource mode will list the specified resources together with the role assignments directly assigned on the resources via `azlist`, which in turn will query the specified resources via ARG's `Resource` table, using a predict like `id in (id1, id2,...)`. The problem is that not all resource types are supported in the `Resource` table (e.g. template deployment resource). Also, it makes no sense to ask the user to specify the ARG table in the resource mode. This PR updates the `azlist` dependency, use the new `ListByIds()` API to list those specified resources, together with the extension resources. This gets rid of querying from ARG to avoid un-supported resource types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when
--include-role-assignmentis specified, the resource mode will list the specified resources together with the role assignments directly assigned on the resources viaazlist, which in turn will query the specified resources via ARG'sResourcetable, using a predict likeid in (id1, id2,...).The problem is that not all resource types are supported in the
Resourcetable (e.g. template deployment resource). Also, it makes no sense to ask the user to specify the ARG table in the resource mode.This PR updates the
azlistdependency, use the newListByIds()API to list those specified resources, together with the extension resources. This gets rid of querying from ARG to avoid un-supported resource types.