This repository was archived by the owner on Feb 4, 2026. It is now read-only.
Open
Conversation
Contributor
🦙 MegaLinter status: ❌ ERROR
See detailed report in MegaLinter reports |
marclerwick
reviewed
Jan 30, 2023
hattan
suggested changes
Feb 2, 2023
Contributor
hattan
left a comment
There was a problem hiding this comment.
In addition to inline comments, please provide a readme that explains how the docs-site is build, what are the dependencies (tailwind, astro) and instructions on generating docs locally for contributors.
In addition, we should clearly document the expected conventions in comments.
marclerwick
reviewed
Feb 7, 2023
marclerwick
suggested changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #130
published sample site can be seen here; https://enpolatmsft.github.io/benchpress/