[eno] Add telemetry for MissingInput and OutofStepInputs#602
Merged
Conversation
tilnl
approved these changes
May 15, 2026
xiazhan
reviewed
May 15, 2026
Collaborator
xiazhan
left a comment
xiazhan
left a comment
There was a problem hiding this comment.
Code review — LGTM with non-blocking comments. Nice refactor: Exist/OutOfLockstep delegating to richer Missing/Mismatched helpers is a clean way to surface telemetry, and the new tests are thorough. A few inline notes below.
xiazhan
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance telemetry so that we know what inputs are missing and what inputs are out of step