fix: update values for gpu operator network operator#1025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR corrects the file path locations for network operator manifest files, changing from the incorrect /net/ subdirectory to the correct /network-operator/ subdirectory. The PR also adds the corresponding configuration files that were missing.
Changes:
- Updated file paths in
install_network_operatorfunction to reference the correctnetwork-operatorsubdirectory - Added network operator configuration files (values.yaml, nfd-network-rule.yaml, nic-cluster-policy.yaml)
- Added GPU operator configuration file (values.yaml)
Reviewed changes
Copilot reviewed 1 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/python/gpu/pkg/net.py | Updated paths for NFD network rule and NIC cluster policy manifests from /net/ to /network-operator/ |
| modules/python/gpu/cfg/network-operator/values.yaml | Added Helm values configuration for network operator with NFD node feature rules disabled |
| modules/python/gpu/cfg/network-operator/nic-cluster-policy.yaml | Added NIC cluster policy configuration for OFED driver and SR-IOV device plugin with InfiniBand support |
| modules/python/gpu/cfg/network-operator/nfd-network-rule.yaml | Added node feature rule to label nodes with Mellanox PCI devices |
| modules/python/gpu/cfg/gpu-operator/values.yaml | Added GPU operator Helm values with RDMA enabled and other features disabled |
960f19b to
9f4a1a7
Compare
6acc721 to
ef49966
Compare
ef49966 to
699e45c
Compare
alyssa1303
reviewed
Feb 5, 2026
alyssa1303
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the GPU module to standardize the use of the
mpi-operatornamespace for MPI jobs and related resources, reorganizes configuration files, and updates code references accordingly. It also improves test coverage and correctness for MPI operator installation and configuration.Namespace and Resource Management:
mpi-operatornamespace instead ofdefault. This includes updating YAML manifests, code references, and resource management logic. [1] [2] [3] [4] [5] [6] [7] [8]Configuration File Organization:
cfg/mpi/directory tocfg/mpi-operator/to better reflect their usage and to align with the new namespace. [1] [2] [3] [4] [5]Operator Installation and Resource Application:
network-operatordirectory, improving clarity and maintainability.Testing Improvements:
Documentation:
README.mdhas been updated to remove unused configuration options for the Python script, reflecting the current set of supported arguments.