Adding unique node subnet for nodepools#1035
Open
shreyashastantram wants to merge 5 commits intofeature/swiftv2GA/swiftv2scalefrom
Open
Adding unique node subnet for nodepools#1035shreyashastantram wants to merge 5 commits intofeature/swiftv2GA/swiftv2scalefrom
shreyashastantram wants to merge 5 commits intofeature/swiftv2GA/swiftv2scalefrom
Conversation
shreyashastantram
requested review from
alyssa1303,
anson627 and
sumanthreddy29
as code owners
isaac-dasan
reviewed
Jan 28, 2026
Member
isaac-dasan
left a comment
isaac-dasan
left a comment
There was a problem hiding this comment.
Also please remove the chages to matrix file and new-pipeline-test.yml file before merge
| # Helper function to create node subnet with calculated CIDR | ||
| create_node_subnet() { | ||
| local subnet_name=$1 | ||
| local subnet_index=$2 # 0=system, 1-8=userpools, 9=buffer |
Member
There was a problem hiding this comment.
Are we assuming that we'll only have 8 userpools? we have 500 nodes per userpool so for 5000 nodes we'll need 10 pools. I'm concerned we might not have enough subnet space (third octet)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating Unique subnet for nodepools.
Adding max surge as 1 to extend beyond 3500 nodes for podsubnet mode.