Skip to content

Add support for Disk Encryption Sets (DES)#1042

Open
xinWeiWei24 wants to merge 24 commits intomainfrom
xinwei/diskencription
Open

Add support for Disk Encryption Sets (DES)#1042
xinWeiWei24 wants to merge 24 commits intomainfrom
xinwei/diskencription

Conversation

@xinWeiWei24
Copy link
Collaborator

This PR adds support for Disk Encryption Sets (DES), enabling customers to create AKS clusters with a specified DES.

@xinWeiWei24 xinWeiWei24 marked this pull request as ready for review February 3, 2026 05:51
Copilot AI review requested due to automatic review settings February 3, 2026 05:51
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Disk Encryption Set (DES) support to the Azure Terraform modules so AKS clusters can be created with customer-managed key (CMK) disk encryption, and updates the nap-complex perf scenario to exercise the new configuration.

Changes:

  • Introduces a new disk-encryption-set Terraform submodule and new input variables to define DES resources.
  • Wires DES into AKS provisioning paths (Terraform AKS resource + az aks create CLI path), including DES-related RBAC.
  • Updates the nap-complex scenario inputs to provision a DES and reference it from AKS.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
scenarios/perf-eval/nap-complex/terraform-inputs/azure.tfvars Adds DES + key config to the scenario and sets disk_encryption_set_name for AKS CLI usage (also removes firewall/UDR config).
modules/terraform/azure/variables.tf Adds disk_encryption_set_name to AKS configs and introduces disk_encryption_set_config_list.
modules/terraform/azure/main.tf Creates DES modules and passes DES map into aks-cli (and computes DES locals).
modules/terraform/azure/key-vault/main.tf Adjusts Key Vault settings to support CMK/DES requirements (purge protection/soft delete retention).
modules/terraform/azure/disk-encryption-set/variables.tf Defines inputs for DES creation and validation rules.
modules/terraform/azure/disk-encryption-set/main.tf Implements DES creation and Key Vault RBAC assignments for DES identity.
modules/terraform/azure/disk-encryption-set/outputs.tf Exposes DES ID for downstream AKS usage.
modules/terraform/azure/disk-encryption-set/README.md Documents how to use the DES module and its inputs/outputs.
modules/terraform/azure/aks/variables.tf Adds DES inputs (disk_encryption_sets, disk_encryption_set_name) to the AKS module interface.
modules/terraform/azure/aks/main.tf Sets disk_encryption_set_id on the azurerm_kubernetes_cluster resource when configured.
modules/terraform/azure/aks-cli/variables.tf Adds DES inputs (disk_encryption_sets, disk_encryption_set_name) for CLI-driven AKS creation.
modules/terraform/azure/aks-cli/main.tf Adds DES CLI flag generation and DES RBAC assignments (plus cluster lookup for kubelet identity).
jobs/competitive-test.yml Comments out the cleanup step in the pipeline job.

@xinWeiWei24 xinWeiWei24 force-pushed the xinwei/diskencription branch from de66a48 to 70d0f35 Compare February 6, 2026 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant