Add support for Disk Encryption Sets (DES)#1042
Open
xinWeiWei24 wants to merge 24 commits intomainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Disk Encryption Set (DES) support to the Azure Terraform modules so AKS clusters can be created with customer-managed key (CMK) disk encryption, and updates the nap-complex perf scenario to exercise the new configuration.
Changes:
- Introduces a new
disk-encryption-setTerraform submodule and new input variables to define DES resources. - Wires DES into AKS provisioning paths (Terraform AKS resource +
az aks createCLI path), including DES-related RBAC. - Updates the
nap-complexscenario inputs to provision a DES and reference it from AKS.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/perf-eval/nap-complex/terraform-inputs/azure.tfvars | Adds DES + key config to the scenario and sets disk_encryption_set_name for AKS CLI usage (also removes firewall/UDR config). |
| modules/terraform/azure/variables.tf | Adds disk_encryption_set_name to AKS configs and introduces disk_encryption_set_config_list. |
| modules/terraform/azure/main.tf | Creates DES modules and passes DES map into aks-cli (and computes DES locals). |
| modules/terraform/azure/key-vault/main.tf | Adjusts Key Vault settings to support CMK/DES requirements (purge protection/soft delete retention). |
| modules/terraform/azure/disk-encryption-set/variables.tf | Defines inputs for DES creation and validation rules. |
| modules/terraform/azure/disk-encryption-set/main.tf | Implements DES creation and Key Vault RBAC assignments for DES identity. |
| modules/terraform/azure/disk-encryption-set/outputs.tf | Exposes DES ID for downstream AKS usage. |
| modules/terraform/azure/disk-encryption-set/README.md | Documents how to use the DES module and its inputs/outputs. |
| modules/terraform/azure/aks/variables.tf | Adds DES inputs (disk_encryption_sets, disk_encryption_set_name) to the AKS module interface. |
| modules/terraform/azure/aks/main.tf | Sets disk_encryption_set_id on the azurerm_kubernetes_cluster resource when configured. |
| modules/terraform/azure/aks-cli/variables.tf | Adds DES inputs (disk_encryption_sets, disk_encryption_set_name) for CLI-driven AKS creation. |
| modules/terraform/azure/aks-cli/main.tf | Adds DES CLI flag generation and DES RBAC assignments (plus cluster lookup for kubelet identity). |
| jobs/competitive-test.yml | Comments out the cleanup step in the pipeline job. |
de66a48 to
70d0f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for Disk Encryption Sets (DES), enabling customers to create AKS clusters with a specified DES.