Ingress tests for pods#931
Open
shreyashastantram wants to merge 24 commits intofeature/swiftv2GA/swiftv2scalefrom
Open
Ingress tests for pods#931shreyashastantram wants to merge 24 commits intofeature/swiftv2GA/swiftv2scalefrom
shreyashastantram wants to merge 24 commits intofeature/swiftv2GA/swiftv2scalefrom
Conversation
shreyashastantram
requested review from
alyssa1303,
anson627 and
sumanthreddy29
as code owners
miguelgoms
reviewed
Nov 12, 2025
miguelgoms
left a comment
miguelgoms
left a comment
There was a problem hiding this comment.
please revert commented tests on the matrix before merging.
isaac-dasan
reviewed
Nov 12, 2025
| - | | ||
| set -e | ||
| MY_INDEX=${POD_INDEX} | ||
| TARGET_INDEX=$((MY_INDEX + 1)) |
Member
There was a problem hiding this comment.
This will fail for the last pod
Author
There was a problem hiding this comment.
it's handled in line 159, but I have added more deterministic way to identify that pod now.
| name: generate_id | ||
| - job: generate_run_id | ||
| displayName: "Generate Base Run ID" | ||
| steps: |
Member
There was a problem hiding this comment.
I don't think there is any diff in this step right?
Author
There was a problem hiding this comment.
yes, no difference. I will revert back the changes
shreyashastantram
force-pushed
the
shreyash/ingress
branch
from
30541a1 to
9c66ff3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.