[DRAFT]Firewall Support#951
Draft
sumanthreddy29 wants to merge 4 commits intovitto/firewalls_featfrom
Draft
Conversation
sumanthreddy29
commented
Dec 1, 2025
Comment on lines
+2
to
+3
| public_ip_ids = { for name, ip in var.public_ips : name => ip.id } | ||
| public_ip_addresses = { for name, ip in var.public_ips : name => ip.ip_address } |
Collaborator
Author
There was a problem hiding this comment.
you can avoid these two vars and directly use them wherever needed
Add a variable to control AAD enablement in the aks-cli module (aligned with the aks module) and include install-kubelogin steps for AAD support.
…os (#953) Update the NAP complex scenario and configure the network policy and dataplane to use Cilium.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.