Open
Conversation
bb8d631 to
d9a1e49
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces infrastructure and configuration for a new CNI (Container Network Interface) prototype scenario in the perf-eval category. The changes enable testing of ipvlan CNI with stretch clusters by providing Terraform configurations for both Azure AKS and AWS EKS deployments, along with shell scripts and ARM templates for setting up dual IP configurations on VMSS nodes.
Key Changes:
- Added Terraform configuration files for deploying CNI prototype test scenarios on Azure and AWS
- Modified Azure network module variables to support multiple address spaces and prefixes (changed from string to list(string))
- Added shell scripts for stretch cluster setup with ipvlan CNI configuration
- Reduced EKS addon timeout defaults from 20m to 5m
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| scenarios/perf-eval/cni-prototype/terraform-test-inputs/azure.json | New test input configuration with run ID and region for Azure deployments |
| scenarios/perf-eval/cni-prototype/terraform-inputs/azure.tfvars | New AKS cluster configuration with dual-stack networking (IPv4/IPv6) and network-plugin set to "none" |
| scenarios/perf-eval/cni-prototype/terraform-inputs/aws.tfvars | New EKS cluster configuration with VPC, subnets, NAT gateways, and node groups for CNI testing |
| modules/terraform/azure/variables.tf | Updated network config variables to accept list of address spaces/prefixes instead of single strings |
| modules/terraform/azure/network/variables.tf | Updated network config variables to accept list of address spaces/prefixes instead of single strings |
| modules/terraform/azure/network/main.tf | Updated to use list-typed address spaces/prefixes directly without wrapping in arrays |
| modules/terraform/aws/eks/main.tf | Reduced EKS addon timeout defaults from 20 minutes to 5 minutes |
| modules/kustomize/stretch/vmss-dual-ipconfig.json | New ARM template for creating VMSS with dual IP configuration for ipvlan networking |
| modules/kustomize/stretch/stretch.sh | New shell script for creating/updating AKS stretch clusters with ipvlan secondary IP configuration |
| modules/kustomize/stretch/setup_ipvlan.sh | New shell script for configuring ipvlan CNI on Azure VM nodes using IMDS metadata |
d9a1e49 to
eb80363
Compare
cfb3c8a to
848c67d
Compare
848c67d to
a39cdab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.