Skip to content

Bump WrappedSecretKeySerializerVersion flight default to 1, Fixes AB#3684385#3176

Open
p3dr0rv wants to merge 3 commits into
devfrom
pedroro/wrapped-secret-key-serializer-v1
Open

Bump WrappedSecretKeySerializerVersion flight default to 1, Fixes AB#3684385#3176
p3dr0rv wants to merge 3 commits into
devfrom
pedroro/wrapped-secret-key-serializer-v1

Conversation

@p3dr0rv

@p3dr0rv p3dr0rv commented Jul 2, 2026 •
edited by azure-boards Bot
Loading

Copy link
Copy Markdown
Contributor

Updates the default value of the WRAPPED_SECRET_KEY_SERIALIZER_VERSION flight from 0 to 1 in CommonFlight.java, switching the WrappedSecretKey serializer to version 1 by default.

AB#3684385

@p3dr0rv p3dr0rv requested a review from a team as a code owner July 2, 2026 20:18
Copilot AI review requested due to automatic review settings July 2, 2026 20:18
@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

❌ Work item link check failed. Description does not contain AB#{ID}.

Click here to Learn more.

Copilot AI reviewed Jul 2, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the default value for the WRAPPED_SECRET_KEY_SERIALIZER_VERSION flight in CommonFlight, switching the WrappedSecretKey serialization default from the legacy format (ID 0) to the metadata-aware format (ID 1). This affects the default behavior of secret key wrapping persistence/serialization across the Common crypto stack when no overriding flight configuration is provided.

Changes:

  • Change WRAPPED_SECRET_KEY_SERIALIZER_VERSION default from 0 to 1.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

✅ Work item link check complete. Description contains link AB#3684385 to an Azure Boards work item.

@github-actions github-actions Bot changed the title Bump WrappedSecretKeySerializerVersion flight default to 1 Bump WrappedSecretKeySerializerVersion flight default to 1, Fixes AB#3684385 Jul 2, 2026
@p3dr0rv

p3dr0rv commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

@copilot update changelog, do not forget PR ID

Copilot AI requested a review from a team as a code owner July 2, 2026 20:34

Copilot AI commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@copilot update changelog, do not forget PR ID

Added changelog entry in commit Update changelog for PR #3176.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@somalaya somalaya somalaya approved these changes
@fadidurah fadidurah fadidurah approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@p3dr0rv @somalaya @fadidurah