-
Notifications
You must be signed in to change notification settings - Fork 1
fix: 총동 인스타 url -> id로 수정 #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
이 PR은 council 테이블의 Instagram 관련 필드를 URL에서 사용자명(username)으로 변경하는 작업입니다. 데이터베이스 스키마, 엔티티 모델, DTO, 서비스 레이어를 포함한 전체 애플리케이션 계층에서 일관되게 변경이 이루어졌습니다.
Changes:
- 데이터베이스 컬럼명을
instagram_url에서instagram_user_name으로 변경하고 기존 URL 데이터를 사용자명으로 변환하는 마이그레이션 추가 - Instagram 사용자명 형식에 맞는 유효성 검증 규칙으로 업데이트 (영문/숫자/점/밑줄만 허용, 최대 30자)
- 엔티티, DTO, 서비스 레이어에서 필드명과 메서드 파라미터를
instagramUrl에서instagramUserName으로 일관되게 변경
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/resources/db/migration/V12__alter_council_instagram_column.sql | Instagram URL 컬럼을 username 컬럼으로 변경하고, 기존 URL 데이터를 파싱하여 사용자명만 추출하는 마이그레이션 스크립트 |
| src/main/java/gg/agit/konect/domain/council/model/Council.java | 엔티티 필드명을 instagramUrl에서 instagramUserName으로 변경 및 관련 메서드 업데이트 |
| src/main/java/gg/agit/konect/domain/council/dto/CouncilCreateRequest.java | 필드명 변경 및 Instagram 사용자명 형식에 맞는 유효성 검증 규칙 추가 |
| src/main/java/gg/agit/konect/domain/council/dto/CouncilUpdateRequest.java | 필드명 변경 및 Instagram 사용자명 형식에 맞는 유효성 검증 규칙 추가 |
| src/main/java/gg/agit/konect/domain/council/dto/CouncilResponse.java | Response DTO 필드명 변경 및 매핑 로직 업데이트 |
| src/main/java/gg/agit/konect/domain/council/service/CouncilService.java | 서비스 메서드에서 파라미터명 변경 |
src/main/resources/db/migration/V12__alter_council_instagram_column.sql
Outdated
Show resolved
Hide resolved
src/main/java/gg/agit/konect/domain/council/dto/CouncilCreateRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/gg/agit/konect/domain/council/dto/CouncilUpdateRequest.java
Outdated
Show resolved
Hide resolved
src/main/resources/db/migration/V12__alter_council_instagram_column.sql
Outdated
Show resolved
Hide resolved
src/main/java/gg/agit/konect/domain/council/dto/CouncilCreateRequest.java
Show resolved
Hide resolved
src/main/java/gg/agit/konect/domain/council/dto/CouncilUpdateRequest.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔍 개요
🚀 주요 변경 내용
council테이블의instagram_url컬럼을instagram_user_name으로 수정했습니다.그에 따라 인스타 아이디 정책에 맞는 유효성 제약을 수정했습니다.
아이디에
@는 포함하지 않는 가정하에 작성했습니다.💬 참고 사항
✅ Checklist (완료 조건)