Add update load combination to adapter push

[Chrisshort92]

NOTE: Depends on

Issues addressed by this PR

Closes #563

Implements Update functionality for LoadCombinations in Robot_Adapter. The Update method now:

• Locates existing combinations using the Number property via direct Get() call (following Loadcases pattern)
• Updates combination names and replaces case factors
• Validates RobotId/Number consistency and logs errors on mismatch
• Provides clear warnings when combinations don't exist in Robot

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Robot_Toolkit/%23565-add-update-load-combination-to-adapter-push?csf=1&web=1&e=GLPz1q

Changelog

Update functionality for LoadCombinations in Robot_Adapter

Additional comments

[staintono]

Tested using the provided test script, load combinations are updated as expected based on the combination number. Error is thrown if combination does not yet exist in the model, as expected.

[peterjamesnugent]

Can you update the title, folder for the test script and the text for the PR. The body mentions Create methods breaking but does not address it in the PR. Similar for the Fixed Update Method and Technical Improvements, not sure how much it relates to the PR changes. I would keep the change log and description to a minimum for clarity.

I ran the script, but it just tried to update the RobotId for LoadCombination to 100, but it's already set as 100 so it doesn't really test the Update. I tried changing it to 200 and nothing happens:

In your script I would also want to a case that updates the factors, a case that updates the Loadcase and a case that tries to update with empty cases (prompting the error).

[staintono]

@copilot update the PR description to summarise the current state of the changes.

[Copilot]

@staintono I've opened a new pull request, #575, to work on those changes. Once the pull request is ready, I'll request review from you.

[staintono]

Can you update the title, folder for the test script and the text for the PR. The body mentions Create methods breaking but does not address it in the PR. Similar for the Fixed Update Method and Technical Improvements, not sure how much it relates to the PR changes. I would keep the change log and description to a minimum for clarity.

I ran the script, but it just tried to update the RobotId for LoadCombination to 100, but it's already set as 100 so it doesn't really test the Update. I tried changing it to 200 and nothing happens:

In your script I would also want to a case that updates the factors, a case that updates the `Loadcase` and a case that tries to update with empty cases (prompting the error).

PR Title and Folder have been updated. Updated the code to include errors where the RobotId doesnt equal the Loadcombination Number, it wont update unless they are both the same. Test script has been updated to include updating just factors or load cases.

[staintono]

@BHoMBot Check Compliance

[Chrisshort92]

I have just re-tested this functionality and works as expected with the update functions @staintono states above. @peterjamesnugent can you re-review ready for merge?

[peterjamesnugent]

Some changes that were not covered in the test scripts, handling of null and where to exit the routine as well as warning and error messaging.

[Chrisshort92]

@BHoMBot check required

[bhombot-ci]

@Chrisshort92 to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[Chrisshort92]

@BHoMBot check core

[bhombot-ci]

@Chrisshort92 to confirm, the following actions are now queued:

• check core

There are 1 requests in the queue ahead of you.

[Chrisshort92]

@BHoMBot check required

[bhombot-ci]

@Chrisshort92 to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 6 requests in the queue ahead of you.

[Chrisshort92]

All comments now addressed

[Chrisshort92]

@BHoMBot check required

[bhombot-ci]

@Chrisshort92 to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

There are 2 requests in the queue ahead of you.

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.