-
Notifications
You must be signed in to change notification settings - Fork 10
Ia 2240 refactor all use delete hooks #2611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quang-le
requested changes
Dec 16, 2025
Member
quang-le
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. Not all might require a change, but please answer:
- TableWithDeepLink
ifstatement - Inconsistent queryKey invalidation
- missing queryKeys in invalidation
hat/assets/js/apps/Iaso/components/tables/TableWithDeepLink.tsx
Outdated
Show resolved
Hide resolved
hat/assets/js/apps/Iaso/domains/orgUnits/orgUnitTypes/hooks/useDeleteOrgUnitType.ts
Show resolved
Hide resolved
quang-le
approved these changes
Dec 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : https://bluesquare.atlassian.net/browse/IA-2240
Self proofreading checklist
Changes
Added the useDeleteTableRow hook into the useDelete hooks of these following components:
-entitytypes
-forms
-Budget
-Grouped Campaigns
-Teams
-planning
-OrgUniTypes Groups
-OrgUniTypes
I didn't make any changes in these following components yet:
-useDeleteBeneficiary
-useDeleteAssignements
-useDeleteAction
-useDeleteInstance
-useDeleteWorkflowChange
-useDeleteWorkflowFollowup
-useDeleteWorkflowVersion
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.