IA-2044: Adding id to org unit base info tab #2630
Open
+23
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quang-le
requested changes
Dec 24, 2025
Member
quang-le
left a comment
quang-le
left a comment
There was a problem hiding this comment.
Since the field is not editable it should go with in the Paper that contains other non-editable info.
Also please use iaso.label.id to avoid adding an json key
beygorghor
changed the title
quang-le
requested changes
Jan 6, 2026
| disabled={disabled} | ||
| /> | ||
| </FormControlComponent> | ||
| </FormControlComponent> |
Member
There was a problem hiding this comment.
You need ton configure your linter to remove these trailing spaces
| <TableBody> | ||
| <Row | ||
| label={formatMessage(MESSAGES.ID)} | ||
| value={orgUnit.id ?? '-'} |
Member
There was a problem hiding this comment.
Suggested change
| value={orgUnit.id ?? '-'} | |
| value={orgUnit.id ?? textPlaceholder} |
You need to add the import from bluesquare-components
quang-le
requested changes
Jan 6, 2026
| "iaso.stock.version.dialog.delete": "¿Estás seguro de que quieres eliminar esta versión?", | ||
| "iaso.tasks.no_logs_to_show": "No hay registros para mostrar." | ||
| "iaso.tasks.no_logs_to_show": "No hay registros para mostrar.", | ||
| "iaso.orgUnits.id": "ID" |
| "iaso.orgUnits.forms.noData": "Aucun formulaire", | ||
| "iaso.orgUnits.formsHelperText": "Soumissions du formulaire", | ||
| "iaso.orgUnits.GPSWarning": "Les coordonnées GPS ne seront PAS mises à jour pour les unités d'org qui ont déjà des données géographiques", | ||
| "iaso.orgUnits.id": "ID", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : https://bluesquare.atlassian.net/browse/IA-2044
Self proofreading checklist
Changes
The Org unit base info tab didn't display the ID. The user had to navigate to the main org unit lists. I added the ID so that it can be displayed with other org units elements.
How to test
Go to Org unit list, click on the view button in the action cell, the info tab should display the details of the org unit with its ID.
Print screen / video
Upload here print screens or videos showing the changes.
Notes
Things that the reviewers should know:
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.