-
Notifications
You must be signed in to change notification settings - Fork 10
POLIO-2013 integrated campaign api #2631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TODO: replace obr name with ID to simplify validation
- replace serializerFields - update tests
tdethier
approved these changes
Jan 6, 2026
Member
|
I forgot to include a general comment in the review so here it is @quang-le:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem is this PR solving? Explain here in one sentence.
Related JIRA tickets : POLIO-1997, POLIO-2013
Self proofreading checklist
Doc
In the tests
Changes
PrimaryKeyRelatedFieldtoCampaignSerializerintegrated_toandintegrated_campaignsRetrieveCampaignSerializerto format front-end friendly responseHow to test
integrated_toandintegrated_campaignsshould be presentintegrated_towith another campaign's id and saveintegrated_campaignswith a list of campaign ids and saveExpected behaviour:
integrated_tomust be a polio campaign idintegrated_campaignscannot contain polio campaigns idsintegrated_tomust be null for a polio campaignintegrated_campaignsmust be empty for non-polio campaignPrint screen / video
NA