IA-4677: Fix unnecessary annotations with form possible_fields #2638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: IA-4677
This fixes a performance issue with the
/api/forms/20/?fields=possible_fieldsendpoint, where unnecessary annotations (last instance and instance count) were performed but not used in the response.Self proofreading checklist
Are my typescript files well typed?New translations have been added or updated if new strings have been introduced in the frontendMy migrations file are includedDocumentation has been included (for new feature)Doc
/
Changes
idfor the details action, avoiding the more expensive annotations.How to test
Try pages related to the form endpoint to see if they don't throw exceptions:
If a specific config is required explain it here: dataset, account, profile, etc.
Print screen / video
/
Notes
I'm not 100% sure about the /manifest/ or /manifest_enketo/ endpoints, that could be affected by this change but I couldn't test with real data.
Follow the Conventional Commits specification
The merge message of a pull request must follow the Conventional Commits specification.
This convention helps to automatically generate release notes.
Use lowercase for consistency.
Example:
Note that the Jira reference is preceded by a line break.
Both the line break and the Jira reference are entered in the Add an optional extended description… field.