[pull] master from libfuse:master#55
Merged
Merged
Conversation
With the old mount(2) syscall, the kernel's SELinux code (selinux_sb_eat_lsm_opts) internally strips double quotes from context option values like context="system_u:object_r:root_t:s0". However, with the new fsconfig() API the value is passed through verbatim, causing SELinux to reject the mount with ENODEV. Strip enclosing double quotes from key=value option values in apply_opt_key_value() before passing them to fsconfig(). Signed-off-by: Jingbo Xu <jingbo.xu@linux.alibaba.com>
The strtok_r(opts, ",", ...) based option splitter does not understand double-quoted values. SELinux MLS labels can contain commas inside quotes (e.g., context="system_u:object_r:root_t:s0:c0,c1"), which would be incorrectly split into separate tokens. Replace strtok_r with a quote-aware next_mount_opt() helper that skips commas inside double-quoted regions. Signed-off-by: Jingbo Xu <jingbo.xu@linux.alibaba.com> Signed-off-by: Jingbo Xu <jefflexu@linux.alibaba.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )