Skip to content

DO NOT MERGE: Update protocol version to 10 for negative testing #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bghgary wants to merge 2 commits into from
Closed

DO NOT MERGE: Update protocol version to 10 for negative testing #1591

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5325a73
Update protocol version to 10 for negative testing
bghgary Jan 15, 2026
36fc1fb
Disable JIT debugging when running with Chakra
bghgary Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/jobs/win32.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ jobs:
displayName: "Add ASAN runtime DLLs to PATH"
condition: ${{parameters.enableSanitizers}}

# When running with Chakra, unhandled JavaScript exceptions trigger the JIT debugger, which
# causes the test to hang. This will disable the JIT debugger for Chakra.
- script: |
for /f %%i in ('vswhere -property instanceId') do (
reg add HKCU\Software\Microsoft\VisualStudio\Debugger\JIT\{F200A7E7-DEA5-11D0-B854-00A0244A1DE2}\%%i /f /v Disabled /t REG_DWORD /d 1
)
displayName: "Disable JIT Debugger for Script"

- script: |
cd build${{variables.solutionName}}\Apps\Playground
cd RelWithDebInfo
Expand Down
2 changes: 1 addition & 1 deletion Plugins/NativeEngine/Source/NativeEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ namespace Babylon
JS_CLASS_NAME,
{
// This must match the version in nativeEngine.ts
StaticValue("PROTOCOL_VERSION", Napi::Number::From(env, 9)),
StaticValue("PROTOCOL_VERSION", Napi::Number::From(env, 10)),

StaticValue("CAPS_LIMITS_MAX_TEXTURE_SIZE", Napi::Number::From(env, limits.maxTextureSize)),
StaticValue("CAPS_LIMITS_MAX_TEXTURE_LAYERS", Napi::Number::From(env, limits.maxTextureLayers)),
Expand Down
Loading