Add servicesJsonRoute option and remove unneeded dependency#99
Merged
jkyberneees merged 3 commits intoBackendStack21:masterfrom May 15, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new option to control the exposure of service documentation via a JSON route and removes an unneeded dependency.
- Added a new servicesJsonRoute option with a default value of true in gateway configuration.
- Replaced the usage of @polka/send-type with a built‐in response method for serving /services.json.
- Updated documentation to reflect the new option and version changes.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Removed the unneeded @polka/send-type dependency. |
| index.js | Added servicesJsonRoute option and updated the JSON route handler. |
| docs/README.md | Updated documentation to include the new servicesJsonRoute option. |
jkyberneees
requested changes
May 14, 2025
jkyberneees
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💻 Code example:
ℹ️ Note:
I used version number 4.2.0 in the documentation, assuming that will be the next release version. Please let me know if a different version is used.